Update documentation to new Custom Resource Definitions#203
Merged
Conversation
…ion in linkerd-examples
siggy
approved these changes
Jan 3, 2018
Member
siggy
left a comment
There was a problem hiding this comment.
Thanks for doing this!
If a user has a k8s cluster <1.8, is it possible they'll still need to configure a ThirdPartyResource rather than a CustomResourceDefinition? If so, consider keeping mention of the old stuff.
Member
|
for reference: #183 |
Contributor
Author
|
Good point. I will mention that in the Readme. Should I also create a separate yml for k8s environments that are still using ThirdPartyResources? |
Member
|
Yeah, I'd keep everything folks need for pre-1.8 k8s. |
Open
siggy
approved these changes
Jan 5, 2018
thanks!| verbs: ["get", "watch", "list"] | ||
| --- | ||
| # grant namerd permisisons to third party resources for dtab storage | ||
| # grant namerd permissions to custom resource definitions for dtab storage |
Member
There was a problem hiding this comment.
since the contents of this file are identical to linkerd-rbac-beta-legacy.yml, i'd say just drop that other file, and update this comment to call out TPR for k8s <1.8, CRD for >=1.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is still some documentation that still references the old ThirdPartyResource APIs. This PR fixes theses references and updates any links that referred to the old k8s TPR API.