-
Notifications
You must be signed in to change notification settings - Fork 2
Resolve PR 868 catalogue rebase #895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
833aa71
Fix search palette and catalogue filtering
ashleyshaw 3c0bc94
Potential fix for pull request finding
ashleyshaw 6c7c8d1
Potential fix for pull request finding
ashleyshaw be9dffa
fix: allow audit replay branches
ashleyshaw 576b374
chore: retrigger checks
ashleyshaw de867f8
Update website/src/scripts/search-utils.js
krugazul d4d4305
Update website/src/scripts/search.js
krugazul 1be0244
chore: bump frontmatter last_updated and version for changed files
claude 082c458
Merge branch 'develop' into pr-868-audit
ashleyshaw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| /** | ||
| * @jest-environment jsdom | ||
| */ | ||
|
|
||
| const { spawnSync } = require("child_process"); | ||
| const path = require("path"); | ||
|
krugazul marked this conversation as resolved.
|
||
|
|
||
| const scriptPath = path.join(__dirname, "../validate-branch-name.js"); | ||
|
|
||
| function runValidator(branchName) { | ||
| return spawnSync(process.execPath, [scriptPath, "--branch", branchName], { | ||
| encoding: "utf8", | ||
| }); | ||
|
krugazul marked this conversation as resolved.
|
||
| } | ||
|
|
||
| describe("Branch name validation", () => { | ||
| it("accepts temporary audit replay branches", () => { | ||
| const result = runValidator("pr-895-audit"); | ||
|
|
||
| expect(result.status).toBe(0); | ||
| expect(result.stdout).toContain( | ||
| "matches the repository branching strategy", | ||
| ); | ||
| }); | ||
|
|
||
| it("rejects malformed branch names", () => { | ||
| const result = runValidator("audit-branch"); | ||
|
|
||
| expect(result.status).toBe(1); | ||
| expect(result.stderr).toContain("does not follow the required format"); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.