Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(changelog): Phase 1 - Conventional commits parsing and auto-categorization #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat(changelog): Phase 1 - Conventional commits parsing and auto-categorization #630
Changes from all commits
26f08f484c9a917e7de234172e117a6d1898c286ae8418d58ce309d30db360475af6583e081d1bc441c84e4369cFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: lightspeedwp/.github
Length of output: 1078
🏁 Script executed:
Repository: lightspeedwp/.github
Length of output: 164
🏁 Script executed:
Repository: lightspeedwp/.github
Length of output: 1970
🌐 Web query:
Jest API test.failing() exists?💡 Result:
Yes, the test.failing method exists in Jest and is supported [1]. This method allows you to define a test that is expected to fail; if the test throws an error or rejects, Jest considers it a passing test, whereas if the test passes unexpectedly, Jest will mark it as a failure [1][2]. This feature is often used to document known bugs or to TDD (Test Driven Development) a fix for an issue where the test currently fails [2]. It is similar to functionality found in other test runners like AVA or pytest [2]. If you are trying to verify that a specific function throws an error or rejects a promise rather than declaring an entire test as failing, you should use Jest's built-in assertion matchers instead, such as.toThrow or.rejects [3][4].
Citations:
test.failingmethod jestjs/jest#12610Avoid hiding failing Jest tests via
.jest-skip/testPathIgnorePatternsin.jest.config.cjsignores<rootDir>/.jest-skip/, so those tests are completely invisible to CI. Right now.jest-skip/contains 28*.test.js/tsfiles (e.g.planner.agent.test.js,reviewer.agent.test.js,validate-structure.test.js), and the repo’s own planning docs track this as “Tests disabled” with an explicit issue to move them out—so this is a real reliability gap, not just a temporary tidy-up.For known failures, keep them visible in the suite instead:
describe.skip()/test.skip()inline with a clear TODO + linked issuetest.failing()when you intentionally expect a failure🤖 Prompt for AI Agents
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: lightspeedwp/.github
Length of output: 716
🏁 Script executed:
rg -n '^function determineSection\(type, labels = \[\]\) \{$' scripts/agents/includes/categoryMapper.js node --check scripts/agents/includes/categoryMapper.jsRepository: lightspeedwp/.github
Length of output: 363
Fix parse-breaking duplicate
determineSectionheader (syntax error)categoryMapper.jsdeclaresfunction determineSection(type, labels = []) {twice on adjacent lines (82–83), andnode --checkfails withSyntaxError: Unexpected end of input—the module won’t parse correctly.🛠️ Proposed fix
function determineSection(type, labels = []) { -function determineSection(type, labels = []) { // Check labels first (higher priority) const safeLabels = Array.isArray(labels) ? labels : []; for (const label of safeLabels) { const section = mapLabelToSection(label); if (section) return section; }📝 Committable suggestion
🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.