Skip to content

[AI Ops] Close issue #32 child labeling gaps#412

Merged
ashleyshaw merged 1 commit into
developfrom
ai/issue-32-full-closeout
May 26, 2026
Merged

[AI Ops] Close issue #32 child labeling gaps#412
ashleyshaw merged 1 commit into
developfrom
ai/issue-32-full-closeout

Conversation

@ashleyshaw

@ashleyshaw ashleyshaw commented May 26, 2026

Copy link
Copy Markdown
Member

Summary

This PR completes the remaining child issue work for parent #32 by fixing live labeling bugs and finishing markdown standards alignment.

Implemented

  • Fix canonical type mapping bug in labeling.agent.js (type:accessibility -> type:a11y).
  • Add guardrails so non-canonical detected type labels are skipped with explicit warnings.
  • Fix labeling workflow checkout behaviour by removing hard-pinned ref: develop to allow correct event ref context.
  • Add active .github/instructions/markdown.instructions.md with canonical scope, cross-references, accessibility guidance, validation steps, and contribution/review section.

Validation

  • node scripts/agents/includes/check-template-labels.js
  • npm run validate:workflows
  • npx markdownlint-cli2 .github/instructions/markdown.instructions.md
  • npm run test:js -- scripts/agents/__tests__/labeling.agent.test.js
  • git diff --check

Closes #38
Closes #39
Closes #40
Closes #41
Closes #42
Closes #43
Closes #44
Closes #45
Closes #32

@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@ashleyshaw, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 43 minutes and 55 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 7048ecd6-05e8-4dad-8434-c20c105129a0

📥 Commits

Reviewing files that changed from the base of the PR and between 116b6e0 and f6aa808.

📒 Files selected for processing (3)
  • .github/instructions/markdown.instructions.md
  • .github/workflows/labeling.yml
  • scripts/agents/labeling.agent.js

Note

.coderabbit.yml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized keys: "auto_labels", "auto_assign", "auto_review"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ai/issue-32-full-closeout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ashleyshaw ashleyshaw merged commit 3da92eb into develop May 26, 2026
6 of 10 checks passed
@ashleyshaw ashleyshaw deleted the ai/issue-32-full-closeout branch May 26, 2026 18:52
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Reviewer Summary for PR #412

CI Status:success
Files changed: 3

Recommendations

  • Ready to proceed pending human review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new repo-local Markdown instructions file and updates the labeling agent script to map accessibility keywords and branch prefixes to the canonical type:a11y label instead of type:accessibility. It also adds safety checks to ensure detected labels are canonical before applying them. The review feedback highlights three main issues: a potential TypeError in the labeling agent if a PR description is null, incorrect nesting syntax in the Markdown instructions example, and a requirement to document the label migration in /docs/MIGRATION.md.

const detectedType = detectIssueTypeFromContent(title, body);

if (detectedType) {
if (detectedType && canonicalSet.has(detectedType)) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

If the issue or pull request has an empty description, body will be null. Since detectIssueTypeFromContent does not handle null values defensively (it calls body.toLowerCase()), this will throw a TypeError: Cannot read properties of null (reading 'toLowerCase') and fail the content-based type detection step.

To prevent this, ensure body and title are guarded or defaulted to empty strings before being passed, or update detectIssueTypeFromContent to handle null/undefined values.

Comment on lines +65 to +71
```markdown

```bash
npm run lint:md
```

```

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The example code block is not nested correctly. In Markdown, to nest a fenced code block inside another, the outer block should use more backticks (e.g., four backticks ````) than the inner block (three backticks ```). Otherwise, the first inner closing/opening backticks will prematurely close the outer block.

Update the outer block to use four backticks:

````markdown
```bash
npm run lint:md
```

Comment on lines +86 to +88
a11y: "type:a11y",
accessibility: "type:a11y",
wcag: "type:a11y",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The mapping of type:accessibility to type:a11y represents a label migration. Please ensure this migration is documented in the central /docs/MIGRATION.md file so that contributors can follow the migration rules across the repository.

References
  1. Document migration maps and notes in a central /docs/MIGRATION.md file to ensure contributors can follow migration rules mentioned in README files across the repository.

@ashleyshaw ashleyshaw self-assigned this May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment