Skip to content

Update llama-stack downstream source image#995

Merged
tisnik merged 1 commit intolightspeed-core:mainfrom
are-ces:fix-downstream-image
Jan 14, 2026
Merged

Update llama-stack downstream source image#995
tisnik merged 1 commit intolightspeed-core:mainfrom
are-ces:fix-downstream-image

Conversation

@are-ces
Copy link
Contributor

@are-ces are-ces commented Jan 14, 2026

Description

Consume the right downstream image

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement

Summary by CodeRabbit

  • Chores
    • Updated container image used for testing infrastructure.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 14, 2026

Walkthrough

Updated the Docker base image in test.containerfile from quay.io/aipcc/llama-stack/cpu-ubi9:rhoai-3.2 to quay.io/rhoai/odh-llama-stack-core-rhel9:rhoai-3.2. All subsequent build steps remain unchanged.

Changes

Cohort / File(s) Change Summary
Docker Configuration
test.containerfile
Updated base image reference to new container registry

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the llama-stack downstream source image, which aligns with the PR's objective to consume the correct downstream image.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.



📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa68e43 and cc6f682.

📒 Files selected for processing (1)
  • test.containerfile
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: blublinsky
Repo: lightspeed-core/lightspeed-stack PR: 972
File: src/models/config.py:459-513
Timestamp: 2026-01-12T10:58:50.251Z
Learning: In the lightspeed-stack repository, when a user claims a fix is done but the code still shows the original issue, verify the current state of the code before accepting the fix.
📚 Learning: 2025-08-18T10:56:55.349Z
Learnt from: matysek
Repo: lightspeed-core/lightspeed-stack PR: 292
File: pyproject.toml:0-0
Timestamp: 2025-08-18T10:56:55.349Z
Learning: The lightspeed-stack project intentionally uses a "generic image" approach, bundling many dependencies directly in the base runtime image to work for everyone, rather than using lean base images with optional dependency groups.

Applied to files:

  • test.containerfile
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: build-pr
  • GitHub Check: E2E: library mode / ci
  • GitHub Check: E2E: server mode / ci
  • GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-on-pull-request
🔇 Additional comments (1)
test.containerfile (1)

1-2: Use the correct official Red Hat / ODH llama-stack image path.

The image reference quay.io/rhoai/odh-llama-stack-core-rhel9:rhoai-3.2 does not match the documented official location. According to Red Hat / Open Data Hub guidance, the llama-stack image is published at:

  • quay.io/opendatahub/llama-stack:odh (Developer Preview)
  • registry.redhat.io/rhoai/... (GA release)

Update the FROM statement to reference the correct official image path for your use case.

Likely an incorrect or invalid review comment.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@are-ces are-ces changed the title Fix llama-stack downstream source Update llama-stack downstream source image Jan 14, 2026
Copy link
Contributor

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisnik tisnik merged commit 28caabf into lightspeed-core:main Jan 14, 2026
19 of 23 checks passed
@are-ces are-ces deleted the fix-downstream-image branch February 17, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants