Skip to content

LCORE-952: updated Claude instructions#771

Merged
tisnik merged 1 commit intolightspeed-core:mainfrom
tisnik:lcore-952-updated-claude-instructions
Nov 10, 2025
Merged

LCORE-952: updated Claude instructions#771
tisnik merged 1 commit intolightspeed-core:mainfrom
tisnik:lcore-952-updated-claude-instructions

Conversation

@tisnik
Copy link
Contributor

@tisnik tisnik commented Nov 10, 2025

Description

LCORE-952: updated Claude instructions

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement

Related Tickets & Documents

  • Related Issue #LCORE-952

Summary by CodeRabbit

  • Documentation

    • Standardized indentation and formatting in Project Structure and Test Structure sections.
    • Corrected bullet point alignment and spacing in Quality Assurance section.
    • Adjusted command example formatting for E2E tests and ensured consistent line endings throughout documentation.
  • Chores

    • Enhanced documentation consistency and readability through formatting normalization.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 10, 2025

Walkthrough

This PR corrects formatting and indentation throughout CLAUDE.md, including normalizing section indentation in Project Structure, standardizing bullet points in Test Structure, adjusting command example alignment for E2E tests, and ensuring consistent formatting in the Quality Assurance section.

Changes

Cohort / File(s) Summary
Documentation Formatting
CLAUDE.md
Normalized and realigned indentation in Project Structure and Test Structure sections; corrected command example alignment for E2E tests; standardized bullet formatting and line endings in Quality Assurance section

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • These are purely cosmetic formatting and indentation changes with no logic modifications or content alterations.

Possibly related PRs

Poem

🐰 Whitespace whispers, indents aligned,
Bullets perfectly lined,
CLAUDE.md now stands so neat,
Documentation made complete!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title references updating Claude instructions, which directly relates to the CLAUDE.md file changes documented in the summary, making it relevant to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1a5c345 and f2b9f7c.

📒 Files selected for processing (1)
  • CLAUDE.md (4 hunks)
🧰 Additional context used
🧠 Learnings (13)
📚 Learning: 2025-09-18T16:46:33.353Z
Learnt from: CR
Repo: lightspeed-core/lightspeed-stack PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-18T16:46:33.353Z
Learning: Applies to src/app/**/*.py : Use standard FastAPI imports (from fastapi import APIRouter, HTTPException, Request, status, Depends) in FastAPI app code

Applied to files:

  • CLAUDE.md
📚 Learning: 2025-09-18T16:46:33.353Z
Learnt from: CR
Repo: lightspeed-core/lightspeed-stack PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-18T16:46:33.353Z
Learning: Applies to tests/e2e/features/**/*.feature : Write E2E tests as Gherkin feature files for behave

Applied to files:

  • CLAUDE.md
📚 Learning: 2025-09-18T16:46:33.353Z
Learnt from: CR
Repo: lightspeed-core/lightspeed-stack PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-18T16:46:33.353Z
Learning: Applies to tests/e2e/features/steps/**/*.py : Place behave step definitions under tests/e2e/features/steps/

Applied to files:

  • CLAUDE.md
📚 Learning: 2025-09-18T16:46:33.353Z
Learnt from: CR
Repo: lightspeed-core/lightspeed-stack PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-18T16:46:33.353Z
Learning: Applies to tests/{unit,integration}/**/*.py : Use pytest for all unit and integration tests

Applied to files:

  • CLAUDE.md
📚 Learning: 2025-09-18T16:46:33.353Z
Learnt from: CR
Repo: lightspeed-core/lightspeed-stack PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-18T16:46:33.353Z
Learning: Applies to tests/{unit,integration}/**/*.py : Do not use unittest in tests; pytest is the standard

Applied to files:

  • CLAUDE.md
📚 Learning: 2025-09-18T16:46:33.353Z
Learnt from: CR
Repo: lightspeed-core/lightspeed-stack PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-18T16:46:33.353Z
Learning: Applies to tests/e2e/test_list.txt : Maintain the E2E test list in tests/e2e/test_list.txt

Applied to files:

  • CLAUDE.md
📚 Learning: 2025-09-18T16:46:33.353Z
Learnt from: CR
Repo: lightspeed-core/lightspeed-stack PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-18T16:46:33.353Z
Learning: Run uv run make format and uv run make verify before completion

Applied to files:

  • CLAUDE.md
📚 Learning: 2025-09-18T16:46:33.353Z
Learnt from: CR
Repo: lightspeed-core/lightspeed-stack PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-18T16:46:33.353Z
Learning: Create unit tests for new code and ensure all tests pass

Applied to files:

  • CLAUDE.md
📚 Learning: 2025-09-18T16:46:33.353Z
Learnt from: CR
Repo: lightspeed-core/lightspeed-stack PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-18T16:46:33.353Z
Learning: Use uv as the package manager; prefix commands with uv run

Applied to files:

  • CLAUDE.md
📚 Learning: 2025-09-18T16:46:33.353Z
Learnt from: CR
Repo: lightspeed-core/lightspeed-stack PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-18T16:46:33.353Z
Learning: Applies to pyproject.toml : ALWAYS check pyproject.toml for existing dependencies before adding new ones

Applied to files:

  • CLAUDE.md
📚 Learning: 2025-09-18T16:46:33.353Z
Learnt from: CR
Repo: lightspeed-core/lightspeed-stack PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-18T16:46:33.353Z
Learning: Follow existing code patterns in the module you are modifying

Applied to files:

  • CLAUDE.md
📚 Learning: 2025-09-18T16:46:33.353Z
Learnt from: CR
Repo: lightspeed-core/lightspeed-stack PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-18T16:46:33.353Z
Learning: Applies to pyproject.toml : ALWAYS verify current library versions in pyproject.toml rather than assuming versions

Applied to files:

  • CLAUDE.md
📚 Learning: 2025-09-18T16:46:33.353Z
Learnt from: CR
Repo: lightspeed-core/lightspeed-stack PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-18T16:46:33.353Z
Learning: Applies to **/*.py : Follow Google Python docstring style for modules, classes, and functions, including Args, Returns, Raises, Attributes sections as needed

Applied to files:

  • CLAUDE.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: build-pr
  • GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-on-pull-request
  • GitHub Check: e2e_tests (ci)
  • GitHub Check: e2e_tests (azure)
🔇 Additional comments (2)
CLAUDE.md (2)

15-30: Documentation formatting improvements approved.

The indentation and alignment corrections to the Project Structure tree diagram (lines 18–22) improve visual consistency and readability without altering the content or guidance. Similar improvements have been made throughout the document.


110-150: Test Structure and command alignment improvements approved.

The formatting corrections to the Test Structure section and test command examples maintain clarity and ensure consistent presentation of testing instructions.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tisnik tisnik merged commit 1a5255a into lightspeed-core:main Nov 10, 2025
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant