LCORE-851: fixed issue in test_root.py

[tisnik]

Description

LCORE-851: fixed issue in test_root.py

Type of change

• Refactor
• New feature
• Bug fix
• CVE fix
• Optimization
• Documentation Update
• Configuration Update
• Bump-up service version
• Bump-up dependent library
• Bump-up library or tool used for development (does not change the final image)
• CI configuration change
• Konflux configuration change
• Unit tests improvement
• Integration tests improvement
• End to end tests improvement

Related Tickets & Documents

• Related Issue #LCORE-851

Summary by CodeRabbit

• Tests
  • Enhanced test infrastructure with improved type safety and fixture annotations for better test reliability.
  • Refined authentication test data structures to ensure consistency with application interfaces.

[coderabbitai]

Walkthrough

Updated test file with type annotations for fixtures and refactored authentication mock construction to use the AuthTuple interface instead of a plain tuple, ensuring type safety and alignment with the authentication interface contract.

Changes

Cohort / File(s)	Summary
Test fixture type safety tests/unit/app/endpoints/test_root.py	Added MockerFixture and AuthTuple imports; updated test function signature with MockerFixture type annotation and -> None return type; replaced plain tuple authentication mock ("test_user", "token", {}) with AuthTuple(("test_user_id", "test_user_name", False, "token")).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 With types now sealed and mocks refined,
The test suite shows a clearer mind,
AuthTuple guards what once was loose,
Each parameter finds its proper use!

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title Check	❓ Inconclusive	The title "LCORE-851: fixed issue in test_root.py" references a specific file (test_root.py) and includes a ticket ID for traceability, which directly relates to the changeset. However, the phrase "fixed issue" is generic and non-descriptive—it does not convey what the actual issue was or what the fix involved. A developer scanning through commit history would not understand from this title alone whether the changes are related to type annotations, authentication handling, imports, or another concern entirely. While the title is not misleading or off-topic, it lacks sufficient specificity about the nature of the fix.	Consider revising the title to be more descriptive about the specific fix, such as "LCORE-851: Update test_root.py authentication and type annotations" or similar phrasing that clearly indicates what aspect of the test was fixed or improved. This will help reviewers and future maintainers quickly understand the nature of the changes without requiring additional context.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0d88d3 and 1aacbf3.

📒 Files selected for processing (1)

• tests/unit/app/endpoints/test_root.py (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

**/*.py

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.py: All modules start with descriptive module-level docstrings explaining purpose
Use logger = logging.getLogger(name) for module logging after import logging
Define type aliases at module level for clarity
All functions require docstrings with brief descriptions
Provide complete type annotations for all function parameters and return types
Use typing_extensions.Self in model validators where appropriate
Use modern union syntax (str | int) and Optional[T] or T | None consistently
Function names use snake_case with descriptive, action-oriented prefixes (get_, validate_, check_)
Avoid in-place parameter modification; return new data structures instead of mutating arguments
Use appropriate logging levels: debug, info, warning, error with clear messages
All classes require descriptive docstrings explaining purpose
Class names use PascalCase with conventional suffixes (Configuration, Error/Exception, Resolver, Interface)
Abstract base classes should use abc.ABC and @AbstractMethod for interfaces
Provide complete type annotations for all class attributes
Follow Google Python docstring style for modules, classes, and functions, including Args, Returns, Raises, Attributes sections as needed

Files:

• tests/unit/app/endpoints/test_root.py

tests/{unit,integration}/**/*.py

📄 CodeRabbit inference engine (CLAUDE.md)

tests/{unit,integration}/**/*.py: Use pytest for all unit and integration tests
Do not use unittest in tests; pytest is the standard

Files:

• tests/unit/app/endpoints/test_root.py

tests/**/*.py

📄 CodeRabbit inference engine (CLAUDE.md)

tests/**/*.py: Use pytest-mock to create AsyncMock objects for async interactions in tests
Use the shared auth mock constant: MOCK_AUTH = ("mock_user_id", "mock_username", False, "mock_token") in tests

Files:

• tests/unit/app/endpoints/test_root.py

🧠 Learnings (1)

📚 Learning: 2025-09-18T16:46:33.353Z

Learnt from: CR
PR: lightspeed-core/lightspeed-stack#0
File: CLAUDE.md:0-0
Timestamp: 2025-09-18T16:46:33.353Z
Learning: Applies to tests/**/*.py : Use the shared auth mock constant: MOCK_AUTH = ("mock_user_id", "mock_username", False, "mock_token") in tests

Applied to files:

• tests/unit/app/endpoints/test_root.py

🧬 Code graph analysis (1)

tests/unit/app/endpoints/test_root.py (2)

src/app/endpoints/root.py (1)

• root_endpoint_handler (780-799)

tests/unit/utils/auth_helpers.py (1)

• mock_authorization_resolvers (9-27)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: build-pr
• GitHub Check: e2e_tests (azure)
• GitHub Check: e2e_tests (ci)

🔇 Additional comments (3)

tests/unit/app/endpoints/test_root.py (3)

5-5: LGTM! Type imports improve test type safety.

The addition of MockerFixture and AuthTuple imports enables proper type annotations throughout the test, aligning with the coding guidelines requirement for complete type annotations.

Also applies to: 8-8

---

13-13: LGTM! Complete type annotations added.

The function signature now includes proper type annotations for the mocker parameter and return type, fully complying with the coding guidelines.

---

17-17: The review comment is based on an incorrect assumption about MOCK_AUTH being a shared, importable constant.

After verification, there is no centralized MOCK_AUTH constant. Each test file that uses it defines its own local constant (see test_conversations.py, test_conversations_v2.py, test_tools.py). The conftest.py and auth_helpers.py do not export MOCK_AUTH.

While test_root.py could optionally follow the local pattern and define MOCK_AUTH = ("mock_user_id", "mock_username", False, "mock_token") for consistency, the specific suggestion to import a "shared" constant is incorrect. The coding guideline describing a shared constant is aspirational rather than reflective of the current codebase structure where MOCK_AUTH is locally scoped per test file.

Likely an incorrect or invalid review comment.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}