LCORE-841: fix issues in test_authorized.py

[tisnik]

Description

LCORE-841: fix issues in test_authorized.py

Type of change

• Refactor
• New feature
• Bug fix
• CVE fix
• Optimization
• Documentation Update
• Configuration Update
• Bump-up service version
• Bump-up dependent library
• Bump-up library or tool used for development (does not change the final image)
• CI configuration change
• Konflux configuration change
• Unit tests improvement
• Integration tests improvement
• End to end tests improvement

Related Tickets & Documents

• Related Issue #LCORE-841

Summary by CodeRabbit

• Tests
  • Added type annotations to test functions for improved code quality.

[coderabbitai]

Walkthrough

Three asynchronous test functions receive explicit return type annotations of None. No functional or control flow changes are made; the updates are purely stylistic additions to the function signatures.

Changes

Cohort / File(s)	Change Summary
Type hint additions tests/unit/app/endpoints/test_authorized.py	Added -> None return type annotations to three async test functions: test_authorized_endpoint(), test_authorized_unauthorized(), and test_authorized_dependency_unauthorized(). No logic or behavior modifications.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Types now gleam with clarity and grace,
Three test functions find their rightful place,
With None declared for all to see,
Our tests hop onward—type-safe and free! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title Check	❓ Inconclusive	The pull request title is "LCORE-841: fix issues in test_authorized.py," which refers to the correct file and indicates that fixes are being applied. However, the title uses vague and non-descriptive language by saying "fix issues" without clarifying what specific issues are being addressed. The actual changeset shows that the modifications are specifically about adding return type annotations (-> None) to three async test functions, which is a more precise characterization than the generic term "fix issues." The title does not effectively communicate the nature of the changes to a reviewer scanning the project history.	Consider revising the title to be more specific about the actual changes, such as "LCORE-841: Add return type annotations to test functions in test_authorized.py" or similar wording that clearly describes the addition of type hints rather than the generic phrase "fix issues."

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1ef6c87 and 54ffd39.

📒 Files selected for processing (1)

• tests/unit/app/endpoints/test_authorized.py (3 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

**/*.py

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.py: All modules start with descriptive module-level docstrings explaining purpose
Use logger = logging.getLogger(name) for module logging after import logging
Define type aliases at module level for clarity
All functions require docstrings with brief descriptions
Provide complete type annotations for all function parameters and return types
Use typing_extensions.Self in model validators where appropriate
Use modern union syntax (str | int) and Optional[T] or T | None consistently
Function names use snake_case with descriptive, action-oriented prefixes (get_, validate_, check_)
Avoid in-place parameter modification; return new data structures instead of mutating arguments
Use appropriate logging levels: debug, info, warning, error with clear messages
All classes require descriptive docstrings explaining purpose
Class names use PascalCase with conventional suffixes (Configuration, Error/Exception, Resolver, Interface)
Abstract base classes should use abc.ABC and @AbstractMethod for interfaces
Provide complete type annotations for all class attributes
Follow Google Python docstring style for modules, classes, and functions, including Args, Returns, Raises, Attributes sections as needed

Files:

• tests/unit/app/endpoints/test_authorized.py

tests/{unit,integration}/**/*.py

📄 CodeRabbit inference engine (CLAUDE.md)

tests/{unit,integration}/**/*.py: Use pytest for all unit and integration tests
Do not use unittest in tests; pytest is the standard

Files:

• tests/unit/app/endpoints/test_authorized.py

tests/**/*.py

📄 CodeRabbit inference engine (CLAUDE.md)

tests/**/*.py: Use pytest-mock to create AsyncMock objects for async interactions in tests
Use the shared auth mock constant: MOCK_AUTH = ("mock_user_id", "mock_username", False, "mock_token") in tests

Files:

• tests/unit/app/endpoints/test_authorized.py

🧬 Code graph analysis (1)

tests/unit/app/endpoints/test_authorized.py (1)

src/app/endpoints/authorized.py (1)

• authorized_endpoint_handler (39-55)

🔇 Additional comments (4)

tests/unit/app/endpoints/test_authorized.py (4)

10-10: Verify MOCK_AUTH constant values against coding guidelines.

The MOCK_AUTH constant uses values that differ from the shared auth mock constant specified in the coding guidelines: ("mock_user_id", "mock_username", False, "mock_token"). While this is pre-existing code (not changed in this PR), consider aligning with the standard for consistency across tests.

As per coding guidelines.

---

14-22: Excellent addition of return type annotation.

The -> None return type annotation aligns with the coding guideline requirement for complete type annotations on all functions.

---

26-45: LGTM!

The return type annotation addition is correct and aligns with coding guidelines. The test logic properly validates unauthorized scenarios.

---

49-66: LGTM!

The return type annotation addition is correct and completes the type hints for this test function. The test comprehensively validates unauthorized access scenarios.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}