Skip to content

LCORE-492: set fail-fast to false to let all jobs finish regardless of failures#662

Merged
tisnik merged 1 commit intolightspeed-core:mainfrom
radofuchs:Fix_matrix_jobs_cancel_failure
Oct 13, 2025
Merged

LCORE-492: set fail-fast to false to let all jobs finish regardless of failures#662
tisnik merged 1 commit intolightspeed-core:mainfrom
radofuchs:Fix_matrix_jobs_cancel_failure

Conversation

@radofuchs
Copy link
Contributor

@radofuchs radofuchs commented Oct 13, 2025

Description

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

  • Tests
    • Updated end-to-end test workflow to continue running all matrix jobs even if one fails. This delivers fuller coverage across environments, more reliable results, and clearer diagnostics. Improves CI stability by avoiding premature cancellations and helps identify isolated failures without masking others. No changes to product functionality or user-facing features.

@radofuchs radofuchs requested a review from tisnik October 13, 2025 07:27
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 13, 2025

Walkthrough

Updates the e2e_tests GitHub Actions workflow to set strategy.fail-fast to false, ensuring all matrix jobs continue running even if one fails. No other changes to steps or configuration.

Changes

Cohort / File(s) Summary
CI workflow behavior tweak
\.github/workflows/e2e_tests.yaml
Set strategy.fail-fast: false for matrix runs so jobs do not cancel on first failure; no other modifications.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    actor Dev as Developer
    participant GH as GitHub Actions
    participant M1 as Matrix Job 1
    participant M2 as Matrix Job 2
    participant M3 as Matrix Job 3

    Dev->>GH: Push/PR triggers e2e_tests
    GH->>M1: Start job
    GH->>M2: Start job
    GH->>M3: Start job

    note over GH,M3: strategy.fail-fast = false

    M1-->>GH: Success/Failure
    M2-->>GH: Success/Failure
    M3-->>GH: Success/Failure

    GH-->>Dev: Report all job results (none auto-cancel)
Loading
sequenceDiagram
    autonumber
    participant GH as GitHub Actions
    participant Old as Old Behavior
    participant New as New Behavior

    rect rgb(250,250,210)
    note right of Old: fail-fast = true
    GH->>Old: Start matrix jobs
    Old-->>Old: On first failure, cancel remaining jobs
    end

    rect rgb(210,245,250)
    note right of New: fail-fast = false
    GH->>New: Start matrix jobs
    New-->>New: Continue all jobs to completion
    end
Loading

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I thump the ground—no need to dash,
Let every trial run, no crash-and-slash.
Matrix fields in moonlit rows,
Each hop completes, success or woes.
With calm, cool ears and steady pace,
I test them all—no early race. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly summarizes the main change: configuring fail-fast to false so that all jobs finish even if failures occur, and corresponds directly to the CI workflow modification. It's concise, specific, and reflects the pull request's primary objective.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8cea1a0 and c481f56.

📒 Files selected for processing (1)
  • .github/workflows/e2e_tests.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build-pr
  • GitHub Check: e2e_tests (azure)
  • GitHub Check: e2e_tests (ci)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisnik tisnik merged commit 72453ac into lightspeed-core:main Oct 13, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants