LCORE-492: set fail-fast to false to let all jobs finish regardless of failures#662
Merged
tisnik merged 1 commit intolightspeed-core:mainfrom Oct 13, 2025
Conversation
Contributor
WalkthroughUpdates the e2e_tests GitHub Actions workflow to set strategy.fail-fast to false, ensuring all matrix jobs continue running even if one fails. No other changes to steps or configuration. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant GH as GitHub Actions
participant M1 as Matrix Job 1
participant M2 as Matrix Job 2
participant M3 as Matrix Job 3
Dev->>GH: Push/PR triggers e2e_tests
GH->>M1: Start job
GH->>M2: Start job
GH->>M3: Start job
note over GH,M3: strategy.fail-fast = false
M1-->>GH: Success/Failure
M2-->>GH: Success/Failure
M3-->>GH: Success/Failure
GH-->>Dev: Report all job results (none auto-cancel)
sequenceDiagram
autonumber
participant GH as GitHub Actions
participant Old as Old Behavior
participant New as New Behavior
rect rgb(250,250,210)
note right of Old: fail-fast = true
GH->>Old: Start matrix jobs
Old-->>Old: On first failure, cancel remaining jobs
end
rect rgb(210,245,250)
note right of New: fail-fast = false
GH->>New: Start matrix jobs
New-->>New: Continue all jobs to completion
end
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing
Summary by CodeRabbit