Containerfile COPY adjustment

[omertuc]

Description

We need to do some ugly hack in our assisted-chat repo to make our pipelines work correctly, and it would make it easier for us if we could configure where this Containerfile copies its files from.

It's a bit hard to explain the motivation, but if you don't mind it we would appreciate it if we can have this until we can get rid of the hack in the assisted-chat repo, when LSC has proper releases that we can use out of the box.

Type of change

• Refactor
• New feature
• Bug fix
• CVE fix
• Optimization
• Documentation Update
• Configuration Update
• Bump-up service version
• Bump-up dependent library
• Bump-up library or tool used for development (does not change the final image)
• CI configuration change
• Konflux configuration change
• Unit tests improvement
• Integration tests improvement
• End to end tests improvement

Related Tickets & Documents

• Related Issue #
• Closes #

Checklist before requesting a review

• I have performed a self-review of my code.
• PR has passed all pre-merge test jobs.
• If it is a core feature, I have added thorough tests.

Testing

• Please provide detailed steps to perform tests related to this code change.
• How were the fix/results from this change verified? Please provide relevant screenshots or results.

Tried to build, successfully

Summary by CodeRabbit

• Chores
  • Updated container build process to allow configuring the source directory at build time via a new build argument.

[coderabbitai]

Walkthrough

The Containerfile was updated to introduce a build argument, LSC_SOURCE_DIR, defaulting to the current directory. This argument is now used in the COPY instructions to allow the source directory to be specified at build time, making the build context more flexible. No other changes were made.

Changes

File(s)	Change Summary
Containerfile	Added ARG LSC_SOURCE_DIR=.; updated all COPY commands to use ${LSC_SOURCE_DIR} as the prefix

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5-10 minutes

Suggested reviewers

• matysek
• tisnik

Poem

In the burrow where containers build,
A new path for source is now fulfilled.
With LSC_SOURCE_DIR set just right,
Copying code is now a delight.
Rabbits hop, containers spin—
Flexibility wins again! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e49dcd5 and b904030.

📒 Files selected for processing (1)

• Containerfile (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: build-pr

🔇 Additional comments (3)

Containerfile (3)

5-5: LGTM! Clean parameterization of source directory.

The build argument is well-named, has a sensible default that preserves existing behavior, and is positioned appropriately with other build arguments.

---

19-19: Consider security implications when allowing arbitrary source paths.

The parameterization is implemented correctly and preserves default behavior. However, consider that allowing arbitrary source directories could potentially expose sensitive files if not used carefully in CI/CD pipelines.

Ensure that any CI systems using this parameter validate or restrict the allowed source directory values to prevent accidental exposure of sensitive files.

---

20-20: LGTM! Consistent parameterization across all required files.

The COPY command correctly applies the LSC_SOURCE_DIR parameter to all required files (pyproject.toml, LICENSE, README.md, uv.lock) while preserving the destination behavior.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[tisnik]

it looks ok for me

[matysek]

lgtm