Skip to content

Specify src directory for pydocstyle command in Makefile#186

Merged
tisnik merged 1 commit intolightspeed-core:mainfrom
omkarjoshi0304:dev
Jul 4, 2025
Merged

Specify src directory for pydocstyle command in Makefile#186
tisnik merged 1 commit intolightspeed-core:mainfrom
omkarjoshi0304:dev

Conversation

@omkarjoshi0304
Copy link
Contributor

Description

  • Add src parameter to pydocstyle to target correct directory
  • Resolves docstyle verification issues during build process

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Copy link
Contributor

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it a problem with missing docs in tests?

@omkarjoshi0304
Copy link
Contributor Author

while verifying it is raising an issue with ./venv files

Copy link
Contributor

@umago umago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@umago
Copy link
Contributor

umago commented Jul 4, 2025

is it a problem with missing docs in tests?

I think the problem is that it was targetting the current directory, but we should only care about the src/ as our codebase is under that directory

@tisnik
Copy link
Contributor

tisnik commented Jul 4, 2025

is it a problem with missing docs in tests?

I think the problem is that it was targetting the current directory, but we should only care about the src/ as our codebase is under that directory

ok make sense now.TY

Copy link
Contributor

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@tisnik tisnik merged commit eaa27fb into lightspeed-core:main Jul 4, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants