Conversation
In the README an Authorization example for MCP indicates that the file should contain the `Bearer` section, but that is incorrect. If we the file contents are as indicated in the file then the MCP server will receive the `Authorization` header as `Bearer Bearer sk-abc123def456...` and fail This patch fixes this in the README by removing the `Bearer` word in the file.
We don't document anywhere that for MCP tools to work we need to configure a `remote::model-context-protocol` provider in `run.yaml`. This patch adds a very brief mention of this in the README and update the sample `run.yaml` to reflect this.
WalkthroughDocumentation expanded to explain MCP server configuration, authentication methods (static tokens, Kubernetes, OAuth, client-provided tokens), and header propagation behavior. Example run.yaml updated with MCP tool provider configuration and vector store identification. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
README.md (1)
333-340: Consider addingproviders:context to the YAML snippet for copy/paste safety.The snippet is correct, but showing it nested under
providers:would reduce misconfiguration risk for readers skimming the section.Suggested doc tweak
-```yaml - tool_runtime: - - provider_id: model-context-protocol - provider_type: remote::model-context-protocol - config: {} -``` +```yaml +providers: + tool_runtime: + - provider_id: model-context-protocol + provider_type: remote::model-context-protocol + config: {} +```🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` around lines 333 - 340, Update the YAML example so it's shown nested under a top-level providers context to avoid copy/paste misconfiguration: modify the snippet that contains tool_runtime and provider_id: model-context-protocol (and provider_type: remote::model-context-protocol, config: {}) to be indented under a new providers: key, i.e. wrap the existing tool_runtime block inside providers:, ensuring indentation matches the surrounding examples and the keys tool_runtime, provider_id, provider_type, and config remain unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@README.md`:
- Around line 333-340: Update the YAML example so it's shown nested under a
top-level providers context to avoid copy/paste misconfiguration: modify the
snippet that contains tool_runtime and provider_id: model-context-protocol (and
provider_type: remote::model-context-protocol, config: {}) to be indented under
a new providers: key, i.e. wrap the existing tool_runtime block inside
providers:, ensuring indentation matches the surrounding examples and the keys
tool_runtime, provider_id, provider_type, and config remain unchanged.
Description
Small doc improvements:
Authorizationexamples incorrectly indicates that the file should have theBearersection when it shouldn't.run.yamlunder theetool_runtimethere's a need for the mcp remote provider.Type of change
Tools used to create PR
Manually written.
Summary by CodeRabbit