LCORE-886: fixed Pyright issues in endpoints

[tisnik]

Description

LCORE-886: fixed Pyright issues in endpoints

Type of change

• Refactor
• New feature
• Bug fix
• CVE fix
• Optimization
• Documentation Update
• Configuration Update
• Bump-up service version
• Bump-up dependent library
• Bump-up library or tool used for development (does not change the final image)
• CI configuration change
• Konflux configuration change
• Unit tests improvement
• Integration tests improvement
• End to end tests improvement
• Benchmarks improvement

Tools used to create PR

• Assisted-by: N/A
• Generated by: N/A

Related Tickets & Documents

• Related Issue #LCORE-886

Summary by CodeRabbit

• Tests
  • Enhanced assertion logic for configuration and API error validation tests.
  • Improved null-safety checks for request identifier validation.
  • Strengthened error response detail verification to ensure proper content validation.
  • Added type-safe validation for error detail handling.

[coderabbitai]

Walkthrough

The pull request adds defensive null checks and type casting to two integration test files. Changes include adding assertions to verify data is not None before use, casting dictionary details to explicit types, and verifying dictionary key existence before access.

Changes

Cohort / File(s)	Summary
Test resilience improvements tests/integration/endpoints/test_config_integration.py, tests/integration/endpoints/test_rlsapi_v1_integration.py	Added cast imports from typing and defensive checks: null assertions for request IDs and response data, explicit dictionary type casts for error details, and key existence verification before accessing error response dictionaries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Adding integration tests of /config endpoint. Moving auth and request fictures to conftest.py. #733 — Modifies the same integration test file (test_config_integration.py); current PR tightens assertions and error-detail handling in tests that were added/moved by that PR.

Suggested reviewers

• radofuchs

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: fixing Pyright type-checking issues in endpoint tests through type casting and assertion improvements.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments

tests/integration/endpoints/test_rlsapi_v1_integration.py (1)

225-227: Redundant-but-necessary filter for Pyright — acceptable.

Lines 225–226 assert every rid is not None, but Pyright can't narrow the element type of the set from a loop of assertions, so the if rid is not None guard in the generator on line 227 is still needed for type-checking. Functionally correct.

One minor observation: because the if filter silently skips None values, if the assertions on lines 225–226 were ever removed, a None element would be silently excluded instead of causing a test failure. A comment noting the filter is purely for Pyright would help future readers.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}