LCORE-1285: update llama stack to 0.5.0 by jrobertboos · Pull Request #1112 · lightspeed-core/lightspeed-stack

jrobertboos · 2026-02-06T19:07:56Z

Description

Updated Llama Stack to 0.5.0 in order to enable the network configuration on providers so that TLS and Proxy support can be added.

Type of change

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

Assisted-by: N/A
Generated by: N/A

Related Tickets & Documents

Related Issue: LCORE-1250, LCORE-1252
Closes: LCORE-1285

Checklist before requesting a review

I have performed a self-review of my code.
PR has passed all pre-merge test jobs.
If it is a core feature, I have added thorough tests.

Testing

Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

Release Notes

Chores
- Updated Llama Stack dependencies to version 0.5.0.
Bug Fixes
- Improved text extraction to properly handle plain text content alongside structured content elements.

…api; adjust constants and tests accordingly

coderabbitai · 2026-02-06T19:08:14Z

Walkthrough

This PR upgrades Llama Stack dependencies to version 0.5.0 across project configuration and constants, and updates corresponding test expectations. Additionally, the text extraction utility is enhanced to handle plain string elements within content sequences.

Changes

Cohort / File(s)	Summary
Dependency Version Updates `pyproject.toml`, `src/constants.py`, `tests/e2e/features/info.feature`	Bumps llama-stack, llama-stack-client, and llama-stack-api from versions 0.4.3/0.4.4 to 0.5.0; updates MAXIMAL_SUPPORTED_LLAMA_STACK_VERSION constant and test expectations accordingly.
Text Extraction Enhancement `src/utils/responses.py`	Adds branch in _extract_text_from_content to handle plain string elements by stripping and appending to text_fragments before type-based processing, ensuring raw strings are included in text extraction.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~8 minutes

Possibly related PRs

LCORE-695: bump-up Llama Stack to version 0.2.22 #611: Performs the same dependency version bump for Llama Stack and updates version constraints and tests.
Bumpup llama-stack 0.3.5 #918: Updates the supported llama-stack dependency and MAXIMAL_SUPPORTED_LLAMA_STACK_VERSION constant.
LCORE-599: bump-up Llama Stack version to 0.2.18 #452: Applies the same pattern of bumping llama-stack dependency versions and updating version constant.

Suggested reviewers

tisnik
radofuchs

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly and clearly summarizes the primary change—updating Llama Stack to version 0.5.0, which is the main objective across all modified files.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@pyproject.toml`:
- Around line 31-33: Update the mismatched dependency for llama-stack-api:
replace "llama-stack-api==0.5.0" with the latest published version
"llama-stack-api==0.4.3" (or align all three to a consistent, released version)
so installations won't fail; locate the dependency entry for llama-stack-api in
the pyproject.toml dependency list and change the version string accordingly.

pyproject.toml

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/utils/responses.py`:
- Around line 1082-1084: The code currently appends part.strip() to
text_fragments unconditionally inside the branch that checks isinstance(part,
str); change this to only append when the stripped string is non-empty to avoid
inserting empty fragments from whitespace-only parts—update the branch handling
the variables part and text_fragments (where the if isinstance(part, str): ...
continue logic appears) so that you compute stripped = part.strip() and append
stripped only if stripped is truthy.

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2e001ab and 60efb35.

⛔ Files ignored due to path filters (1)

uv.lock is excluded by !**/*.lock

📒 Files selected for processing (4)

pyproject.toml
src/constants.py
src/utils/responses.py
tests/e2e/features/info.feature

🚧 Files skipped from review as they are similar to previous changes (2)

tests/e2e/features/info.feature
pyproject.toml

coderabbitai · 2026-03-03T18:12:29Z

src/utils/responses.py

+        if isinstance(part, str):
+            text_fragments.append(part.strip())
+            continue


⚠️ Potential issue | 🟡 Minor

Avoid appending empty fragments from whitespace-only string parts.

Line 1083 appends part.strip() unconditionally. If part is whitespace-only, this adds "" and can create spacing artifacts in the final joined text.

Suggested fix

- if isinstance(part, str): - text_fragments.append(part.strip()) + if isinstance(part, str): + stripped_part = part.strip() + if stripped_part: + text_fragments.append(stripped_part) continue

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed. In `@src/utils/responses.py` around lines 1082 - 1084, The code currently appends part.strip() to text_fragments unconditionally inside the branch that checks isinstance(part, str); change this to only append when the stripped string is non-empty to avoid inserting empty fragments from whitespace-only parts—update the branch handling the variables part and text_fragments (where the if isinstance(part, str): ... continue logic appears) so that you compute stripped = part.strip() and append stripped only if stripped is truthy.

asimurka · 2026-03-04T09:28:58Z

src/utils/responses.py


    text_fragments: list[str] = []
    for part in content:
+        if isinstance(part, str):


This is not necessary. Function extracts text parts from OpenResponses input/output which is either plain string or sequence of response items i.e., never sequence of plain strings.

asimurka · 2026-03-04T09:29:37Z

src/constants.py

 # Minimal and maximal supported Llama Stack version
 MINIMAL_SUPPORTED_LLAMA_STACK_VERSION = "0.2.17"
-MAXIMAL_SUPPORTED_LLAMA_STACK_VERSION = "0.4.3"
+MAXIMAL_SUPPORTED_LLAMA_STACK_VERSION = "0.5.0"


0.5.1 is already out

Update dependencies to llama-stack version 0.5.0 and add llama-stack-…

2e001ab

…api; adjust constants and tests accordingly

coderabbitai bot reviewed Feb 6, 2026

View reviewed changes

pyproject.toml Show resolved Hide resolved

jrobertboos marked this pull request as draft February 9, 2026 20:13

jrobertboos and others added 5 commits February 9, 2026 15:14

Merge branch 'main' into lcore-1285

5d62e33

Updated test.containerfile to rhoai-3.4

11e8a4a

Merge branch 'main' into lcore-1285

5ff72cd

Update base image in test.containerfile to use upstream Red Hat UBI

de20d7a

fixed type error

60efb35

jrobertboos marked this pull request as ready for review March 3, 2026 18:09

coderabbitai bot reviewed Mar 3, 2026

View reviewed changes

asimurka requested changes Mar 4, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LCORE-1285: update llama stack to 0.5.0#1112

LCORE-1285: update llama stack to 0.5.0#1112
jrobertboos wants to merge 6 commits intolightspeed-core:mainfrom
jrobertboos:lcore-1285

jrobertboos commented Feb 6, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 6, 2026 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot Mar 3, 2026

Uh oh!

asimurka Mar 4, 2026

Uh oh!

asimurka Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jrobertboos commented Feb 6, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Tools used to create PR

Related Tickets & Documents

Checklist before requesting a review

Testing

Summary by CodeRabbit

Release Notes

Uh oh!

coderabbitai bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

asimurka Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

asimurka Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jrobertboos commented Feb 6, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 6, 2026 •

edited

Loading