Skip to content

[LCORE-787] Remove deprecated tests & imports in test_endpoints.py, fix mypy error#1044

Merged
tisnik merged 1 commit intolightspeed-core:mainfrom
max-svistunov:lcore-787-type-errors-endpoints
Jan 22, 2026
Merged

[LCORE-787] Remove deprecated tests & imports in test_endpoints.py, fix mypy error#1044
tisnik merged 1 commit intolightspeed-core:mainfrom
max-svistunov:lcore-787-type-errors-endpoints

Conversation

@max-svistunov
Copy link
Contributor

@max-svistunov max-svistunov commented Jan 22, 2026

Description

Removal of deprecated tests and imports in test_endpoints.py.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: Claude Opus 4.5
  • Generated by: Claude Opus 4.5

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

  • Tests
    • Improved type annotations in test infrastructure for enhanced code clarity.
    • Removed deprecated test cases and streamlined test validations.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 22, 2026

Walkthrough

Two code quality updates: first file adds type annotations to a logging method with imports, second file removes deprecated test cases and associated scaffolding from the test suite, reducing test coverage for obsolete agent retrieval APIs.

Changes

Cohort / File(s) Summary
Type Annotation Update
tests/e2e/mock_jwks_server/server.py
Added typing import and annotated *args parameter with Any type in Handler.log_message method signature.
Deprecated Test Removal
tests/unit/utils/test_endpoints.py
Removed deprecated test cases for get_agent and get_temp_agent flows, eliminated associated imports and scaffolding. Added pyright ignore annotations to QueryRequest constructions without affecting runtime behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • radofuchs
  • tisnik
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: removing deprecated tests and imports from test_endpoints.py and fixing a mypy error, which aligns with the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisnik tisnik merged commit 47ded02 into lightspeed-core:main Jan 22, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants