funding: fix stream handling issues in consumePendingOpenChannels#507
Merged
Conversation
In this commit, we fix a few issues with the streaming handling: 1. If it got an error on Recv() it would just spin for ever, generating an endless stream of spammy logs. 2. It never listened on the Done() context channel for the stream. So if the `lnd` had actually hung up, it wouldn't detect that and would just keep spinning. To make things more graceful, we also add back off when we try to reconnect.
guggero
approved these changes
Jul 2, 2025
guggero
left a comment
Contributor
There was a problem hiding this comment.
Very nice, LGTM 🎉
Thanks a lot for the fix. I updated the server to use this commit and ran a full itest suite, no issues there.
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this commit, we fix a few issues with the streaming handling:
lndhad actually hung up, it wouldn't detect that and would just keep spinning.To make things more graceful, we also add back off when we try to reconnect.