Add GetObjectApiTest, PutObjectsApiTest, ListKeyVersionsApiTest#12
Merged
G8XSU merged 2 commits intolightningdevkit:mainfrom Jun 15, 2023
Merged
Add GetObjectApiTest, PutObjectsApiTest, ListKeyVersionsApiTest#12G8XSU merged 2 commits intolightningdevkit:mainfrom
G8XSU merged 2 commits intolightningdevkit:mainfrom
Conversation
This was referenced May 25, 2023
Closed
G8XSU
commented
May 25, 2023
| } | ||
|
|
||
| @Test | ||
| void execute_ValidPayload_ReturnsResponse() { |
Contributor
Author
There was a problem hiding this comment.
i tried creating a common base testcase but it was more complex and less readable since many api specific calls are interleaved.
Contributor
Author
There was a problem hiding this comment.
these are the abstract methods a sub-test would have had to implement in that case, and it seemed difficult to understand test-case.
abstract void beforeEachSetup();
abstract void verifyAfterTest();
abstract GeneratedMessageV3 createExpectedRequest();
abstract GeneratedMessageV3 createExpectedResponse();
abstract Response executeValidRequest();
abstract Response executeErroringRequest(Class<? extends Exception> exceptionClass)
throws Exception;
jkczyz
reviewed
Jun 1, 2023
| .build(); | ||
| byte[] payload = expectedRequest.toByteArray(); | ||
| when(mockKVStore.get(any())).thenThrow( | ||
| exceptionClass.getDeclaredConstructor(String.class).newInstance("errorMsg")); |
Contributor
There was a problem hiding this comment.
Wouldn't be simpler to pass in the constructed exception?
jkczyz
approved these changes
Jun 13, 2023
Contributor
Author
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #10