Add Unit tests for VssAccessor

[G8XSU]

Depends on #1 and #2

[tnull]

Needs a rebase it seems:

> cargo test
   Compiling vss-accessor v0.1.0 (/Users/ero/workspace/vss-rust-client/vss-accessor)
error[E0308]: arguments to this method are incorrect
  --> vss-accessor/tests/tests.rs:32:31
   |
32 |         let actual_result = vss_acc.get("store", "k1").await.unwrap();
   |                                     ^^^ -------  ---- expected struct `String`, found `&str`
   |                                         |
   |                                         expected struct `String`, found `&str`
   |
note: associated function defined here
  --> /Users/ero/workspace/vss-rust-client/vss-accessor/src/lib.rs:29:15
   |
29 |     pub async fn get(&self, store: String, key: String) -> Result<GetObjectResponse, VssError> {
   |                  ^^^
help: try using a conversion method
   |
32 |         let actual_result = vss_acc.get("store".to_string(), "k1").await.unwrap();
   |                                                ++++++++++++
help: try using a conversion method
   |
32 |         let actual_result = vss_acc.get("store", "k1".to_string()).await.unwrap();
   |                                                      ++++++++++++

error[E0308]: arguments to this method are incorrect
  --> vss-accessor/tests/tests.rs:64:31
   |
64 |         let actual_result = vss_acc.put("store", Some(4), "k1", 2, b"k1v3").await.unwrap();
   |                                     ^^^ -------           ---- expected struct `String`, found `&str`
   |                                         |
   |                                         expected struct `String`, found `&str`
   |
note: associated function defined here
  --> /Users/ero/workspace/vss-rust-client/vss-accessor/src/lib.rs:46:15
   |
46 |     pub async fn put(
   |                  ^^^
help: try using a conversion method
   |
64 |         let actual_result = vss_acc.put("store".to_string(), Some(4), "k1", 2, b"k1v3").await.unwrap();
   |                                                ++++++++++++
help: try using a conversion method
   |
64 |         let actual_result = vss_acc.put("store", Some(4), "k1".to_string(), 2, b"k1v3").await.unwrap();
   |                                                               ++++++++++++

...

[tnull]

Some more comments, let me know if this is good for another round of review.

[G8XSU]

• to keep msrv low
• will eventually start enforcing it

[jkczyz]

It would be better to inline the request here so the test is self-contained. Otherwise, you have to jump to the end of the file to see how this relates to the response.

[G8XSU]

I agree,
in fact it was like that earlier, only reason i extracted it to function was because it was repeated ~4 times.

Personally i prefer test to be self-contained as well than to over-emphasize on not repeating.

Inlining such functions.

[jkczyz]

Little more idiomatic to initialize using one statement.

let mock_response = GetObjectResponse {
	 value: Some(KeyValue { key: "k1".to_string(), version: 2, value: b"k1v2".to_vec() }),
	..Default::default()
};

[G8XSU]

Makes sense!

[jkczyz]

Wasn't clear to me why this results in an InternalError. In a separate commit, could you add documentation to the enum variants and configure the library as following?

#![deny(missing_docs)]
#![deny(unsafe_code)]

[G8XSU]

Sounds Good, it is already on my todo list 👍

[tnull]

LGTM, mod the outstanding comments.