Skip to content

Comments

Make errors actionable when failing to deserialize a ChannelManager#976

Merged
TheBlueMatt merged 2 commits intolightningdevkit:mainfrom
TheBlueMatt:2021-06-actionable-errors
Jul 1, 2021
Merged

Make errors actionable when failing to deserialize a ChannelManager#976
TheBlueMatt merged 2 commits intolightningdevkit:mainfrom
TheBlueMatt:2021-06-actionable-errors

Conversation

@TheBlueMatt
Copy link
Collaborator

@TheBlueMatt TheBlueMatt commented Jun 30, 2021

@TheBlueMatt TheBlueMatt mentioned this pull request Jun 30, 2021
Merged
1 task
@codecov
Copy link

codecov bot commented Jun 30, 2021 •
edited
Loading

Codecov Report

Merging #976 (e8110ab) into main (f472907) will decrease coverage by 0.15%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #976      +/-   ##
==========================================
- Coverage   90.63%   90.47%   -0.16%     
==========================================
  Files          60       60              
  Lines       30538    30607      +69     
==========================================
+ Hits        27678    27692      +14     
- Misses       2860     2915      +55
Impacted Files Coverage Δ
lightning/src/ln/channelmanager.rs 83.88% <50.00%> (-0.02%) ⬇️
lightning/src/util/test_utils.rs 82.54% <100.00%> (ø)
lightning/src/util/events.rs 15.15% <0.00%> (-2.15%) ⬇️
lightning/src/ln/functional_tests.rs 97.23% <0.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f472907...e8110ab. Read the comment docs.

ariard
ariard reviewed Jun 30, 2021
View reviewed changes
Copy link

@ariard ariard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise SGTM

@TheBlueMatt TheBlueMatt mentioned this pull request Jun 30, 2021
Merged
@TheBlueMatt
Make errors actionable when failing to deserialize a ChannelManager
e7560c8
@TheBlueMatt
Correct test log printing due to inverted comparison
e8110ab 
We changed the sort order of log levels to be more natural, but this
comparison wasn't updated accordingly. Likely the reason it was
left strange for so long is it also had the comparison argument
ordering flipped.
@TheBlueMatt TheBlueMatt force-pushed the 2021-06-actionable-errors branch from b918220 to e8110ab Compare June 30, 2021 16:12
@TheBlueMatt
Copy link
Collaborator Author

TheBlueMatt commented Jun 30, 2021

Squashed without diff:

$ git diff-tree -U1 b918220d e8110ab3
$

@ariard
Copy link

ariard commented Jun 30, 2021

ACK e8110ab

For the records about e8110ab, it has been there since #91 : https://github.com/rust-bitcoin/rust-lightning/pull/91/files#diff-8b7223022de62dd3acad8a134eb6fc1cb291b0144df8fb0bb63c454860471a77R167

@TheBlueMatt
Copy link
Collaborator Author

TheBlueMatt commented Jul 1, 2021

For the records about e8110ab, it has been there since #91 : https://github.com/rust-bitcoin/rust-lightning/pull/91/files#diff-8b7223022de62dd3acad8a134eb6fc1cb291b0144df8fb0bb63c454860471a77R167

That specific code yes, but I naively swapped the sort order of log levels in #965, which caused the regression.

@TheBlueMatt TheBlueMatt merged commit e7d3781 into lightningdevkit:main Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@valentinewallace valentinewallace valentinewallace approved these changes

+1 more reviewer

@ariard ariard ariard left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TheBlueMatt @ariard @valentinewallace