Invoice chanman utility by valentinewallace · Pull Request #895 · lightningdevkit/rust-lightning

valentinewallace · 2021-04-23T22:18:33Z

~~TODO: tests~~

Based on #893

codecov · 2021-04-23T22:36:27Z

Codecov Report

Merging #895 (7794708) into main (3be185a) will decrease coverage by 0.01%.
The diff coverage is 64.28%.

❗ Current head 7794708 differs from pull request most recent head 4c7be7e. Consider uploading reports for the commit 4c7be7e to get more accurate results

@@            Coverage Diff             @@
##             main     #895      +/-   ##
==========================================
- Coverage   90.38%   90.36%   -0.02%     
==========================================
  Files          57       58       +1     
  Lines       29500    29505       +5     
==========================================
- Hits        26663    26662       -1     
- Misses       2837     2843       +6

Impacted Files	Coverage Δ
lightning-invoice/src/de.rs	`80.99% <ø> (-0.15%)`	⬇️
lightning-invoice/src/lib.rs	`83.28% <ø> (-0.06%)`	⬇️
lightning-invoice/src/ser.rs	`91.76% <ø> (-0.19%)`	⬇️
lightning/src/chain/channelmonitor.rs	`95.45% <ø> (ø)`
lightning/src/chain/keysinterface.rs	`93.01% <0.00%> (-0.62%)`	⬇️
lightning/src/ln/chan_utils.rs	`97.34% <ø> (ø)`
lightning/src/ln/chanmon_update_fail_tests.rs	`97.64% <ø> (ø)`
lightning/src/ln/channel.rs	`87.41% <0.00%> (-0.04%)`	⬇️
lightning/src/ln/channelmanager.rs	`83.38% <ø> (-0.05%)`	⬇️
lightning/src/ln/functional_test_utils.rs	`95.06% <ø> (ø)`
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3be185a...4c7be7e. Read the comment docs.

TheBlueMatt

Looks good.

lightning/src/ln/channelmanager.rs

lightning-invoice/src/lib.rs

lightning/src/ln/channelmanager.rs

lightning-invoice/src/lib.rs

lightning-invoice/Cargo.toml

lightning-invoice/src/lib.rs

TheBlueMatt · 2021-04-28T20:04:26Z

Can now be rebased after the merge of #893.

lightning/Cargo.toml

ariard · 2021-04-28T23:48:47Z

lightning-invoice/src/lib.rs

+		L::Target: Logger,
+	{
+		// Marshall route hints.
+		let our_channels = channelmanager.list_usable_channels();


IIUC this utility returns as routing hints the complete set of our channels, including the non-announced subset one ?

Sounds pretty harmful for privacy, maybe the utility should have a boolean all or otherwise a Vec<short_channel_id> to precise which ones to disclose ?

I think this is the right default to this - in most cases if we're a "client" node we only have one or two channels anyway (and in non-"client" cases we have several channels that are public), and the "real" fix is to generate random short channel ids.

Agree for the "client" node but for a big hub you will disclose all your private channels with spoke if you're also a merchant which is quite the case of a bunch of such nodes. Though opening an issue for now, we'll adjust in function of users feedback.

Right, we ultimately need some heuristic of "we have > 5 public channels, we shouldn't include any route hints at all", probably.

lightning-invoice/src/lib.rs

ariard

Otherwise sounds good to me :)

lightning-invoice/src/lib.rs

fuzz/src/full_stack.rs

valentinewallace · 2021-04-29T16:33:21Z

Oops, need to switch sign_invoice to return a Result. Otherwise I think this is roughly what it's gonna look like.

lightning-invoice/src/lib.rs

valentinewallace · 2021-04-29T18:23:51Z

Gonna have lunch then come back to this

lightning/src/chain/keysinterface.rs

lightning/src/ln/channelmanager.rs

lightning/src/chain/keysinterface.rs

lightning-invoice/src/utils.rs

TheBlueMatt

Aside from Jeff's comments and #895 (comment) this LGTM.

lightning-invoice/src/lib.rs

lightning-invoice/src/utils.rs

valentinewallace · 2021-04-29T23:05:05Z

Gah my bad, fixed

lightning-invoice/src/utils.rs

This also allows the ChannelManager to track information for inbound payments to check the PaymentSecret on receive.

Fix merge conflicts between #898 and #895.

TheBlueMatt reviewed Apr 24, 2021

View reviewed changes

lightning/src/ln/channelmanager.rs Outdated Show resolved Hide resolved

lightning-invoice/src/lib.rs Outdated Show resolved Hide resolved

lightning-invoice/src/lib.rs Outdated Show resolved Hide resolved

TheBlueMatt mentioned this pull request Apr 26, 2021

Invoice features #876

Merged

valentinewallace force-pushed the invoice-chanman-utility branch 3 times, most recently from fec5fa5 to 7d5ebb2 Compare April 28, 2021 16:50

valentinewallace marked this pull request as ready for review April 28, 2021 16:50

valentinewallace force-pushed the invoice-chanman-utility branch 4 times, most recently from 78b8298 to 4d5f112 Compare April 28, 2021 18:47

jkczyz reviewed Apr 28, 2021

View reviewed changes

lightning/src/ln/channelmanager.rs Outdated Show resolved Hide resolved

lightning-invoice/src/lib.rs Outdated Show resolved Hide resolved

lightning-invoice/src/lib.rs Outdated Show resolved Hide resolved

TheBlueMatt reviewed Apr 28, 2021

View reviewed changes

lightning-invoice/Cargo.toml Outdated Show resolved Hide resolved

lightning-invoice/src/lib.rs Outdated Show resolved Hide resolved

lightning-invoice/src/lib.rs Outdated Show resolved Hide resolved

lightning-invoice/src/lib.rs Outdated Show resolved Hide resolved

valentinewallace force-pushed the invoice-chanman-utility branch 2 times, most recently from b3d0434 to 5dfb86a Compare April 28, 2021 21:43

TheBlueMatt reviewed Apr 28, 2021

View reviewed changes

lightning/Cargo.toml Show resolved Hide resolved

valentinewallace force-pushed the invoice-chanman-utility branch 2 times, most recently from 8cd714c to 5a478c7 Compare April 28, 2021 22:16

ariard reviewed Apr 28, 2021

View reviewed changes

jkczyz reviewed Apr 29, 2021

View reviewed changes

lightning-invoice/src/lib.rs Outdated Show resolved Hide resolved

fuzz/src/full_stack.rs Outdated Show resolved Hide resolved

valentinewallace force-pushed the invoice-chanman-utility branch 3 times, most recently from 5dd106d to 9ab3a9c Compare April 29, 2021 16:29

valentinewallace force-pushed the invoice-chanman-utility branch 2 times, most recently from 1e34c16 to e2f81e3 Compare April 29, 2021 17:01

jkczyz reviewed Apr 29, 2021

View reviewed changes

TheBlueMatt reviewed Apr 29, 2021

View reviewed changes

valentinewallace force-pushed the invoice-chanman-utility branch from 3c58411 to fbdb7a1 Compare April 29, 2021 18:12

TheBlueMatt reviewed Apr 29, 2021

View reviewed changes

lightning/src/chain/keysinterface.rs Outdated Show resolved Hide resolved

TheBlueMatt added this to the 0.0.14 milestone Apr 29, 2021

TheBlueMatt reviewed Apr 29, 2021

View reviewed changes

lightning/src/ln/channelmanager.rs Outdated Show resolved Hide resolved

valentinewallace force-pushed the invoice-chanman-utility branch 3 times, most recently from c1f9f87 to 50c0a99 Compare April 29, 2021 20:36

TheBlueMatt reviewed Apr 29, 2021

View reviewed changes

lightning/src/chain/keysinterface.rs Outdated Show resolved Hide resolved

valentinewallace force-pushed the invoice-chanman-utility branch from 7794708 to a614b9b Compare April 29, 2021 20:44

jkczyz reviewed Apr 29, 2021

View reviewed changes

lightning-invoice/src/utils.rs Outdated Show resolved Hide resolved

lightning-invoice/src/utils.rs Outdated Show resolved Hide resolved

lightning-invoice/src/utils.rs Outdated Show resolved Hide resolved

lightning-invoice/src/utils.rs Outdated Show resolved Hide resolved

TheBlueMatt reviewed Apr 29, 2021

View reviewed changes

TheBlueMatt mentioned this pull request Apr 29, 2021

Require min_final_cltv_expiry in invoices #898

Merged

valentinewallace force-pushed the invoice-chanman-utility branch from a614b9b to 6173c2c Compare April 29, 2021 22:37

valentinewallace added 4 commits April 29, 2021 18:39

invoice: swap PaymentSecret for ChannelManager's PaymentSecret

9529226

Make _test_utils depend on bitcoinconsensus feature

6f5d816

Move PaymentPreimage+PaymentHash+PaymentSecret to top-level ln module

f24bbd6

Move invoice signing behind KeysInterface

feb882f

valentinewallace force-pushed the invoice-chanman-utility branch from 6173c2c to a6a6130 Compare April 29, 2021 22:39

TheBlueMatt approved these changes Apr 29, 2021

View reviewed changes

jkczyz approved these changes Apr 29, 2021

View reviewed changes

lightning-invoice/src/lib.rs Outdated Show resolved Hide resolved

TheBlueMatt requested changes Apr 29, 2021

View reviewed changes

lightning-invoice/src/utils.rs Outdated Show resolved Hide resolved

valentinewallace force-pushed the invoice-chanman-utility branch from a6a6130 to 8385915 Compare April 29, 2021 23:04

TheBlueMatt reviewed Apr 29, 2021

View reviewed changes

lightning-invoice/src/utils.rs Outdated Show resolved Hide resolved

lightning-invoice/src/utils.rs Outdated Show resolved Hide resolved

Add utility to create an invoice using the ChannelManager

4c7be7e

This also allows the ChannelManager to track information for inbound payments to check the PaymentSecret on receive.

valentinewallace force-pushed the invoice-chanman-utility branch from 8385915 to 4c7be7e Compare April 29, 2021 23:14

TheBlueMatt merged commit 3b67be2 into lightningdevkit:main Apr 29, 2021

TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this pull request Apr 30, 2021

Fix merge conflicts between lightningdevkit#898 and lightningdevkit#895.

8cde7e8

TheBlueMatt added a commit that referenced this pull request Apr 30, 2021

Merge pull request #907 from TheBlueMatt/2021-04-merge-conflicts

e26c3df

Fix merge conflicts between #898 and #895.

Comments

Conversation

valentinewallace commented Apr 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Apr 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

TheBlueMatt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheBlueMatt commented Apr 28, 2021

Uh oh!

Uh oh!

ariard Apr 28, 2021

Choose a reason for hiding this comment

Uh oh!

TheBlueMatt Apr 29, 2021

Choose a reason for hiding this comment

Uh oh!

ariard Apr 29, 2021

Choose a reason for hiding this comment

Uh oh!

TheBlueMatt Apr 29, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ariard left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

valentinewallace commented Apr 29, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

valentinewallace commented Apr 29, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheBlueMatt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

valentinewallace commented Apr 29, 2021

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

valentinewallace commented Apr 23, 2021 •

edited

Loading

codecov bot commented Apr 23, 2021 •

edited

Loading