Skip to content

Remove lazy flag from {KVStore,KVStoreSync}::remove #4116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheBlueMatt merged 1 commit into from
Sep 25, 2025

Remove `lazy` flag from `{KVStore,KVStoreSync}::remove`

561da4c
Select commit
Loading
Failed to load commit list.
Merged

Remove lazy flag from {KVStore,KVStoreSync}::remove #4116

Remove `lazy` flag from `{KVStore,KVStoreSync}::remove`
561da4c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 25, 2025 in 0s

88.54% (+0.01%) compared to d076584

View this Pull Request on Codecov

88.54% (+0.01%) compared to d076584

Details

Codecov Report

❌ Patch coverage is 58.33333% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.54%. Comparing base (d076584) to head (561da4c).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
lightning-persister/src/fs_store.rs 42.10% 7 Missing and 4 partials ⚠️
lightning/src/util/test_utils.rs 60.00% 2 Missing ⚠️
lightning-background-processor/src/lib.rs 0.00% 1 Missing ⚠️
lightning/src/util/persist.rs 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4116      +/-   ##
==========================================
+ Coverage   88.53%   88.54%   +0.01%     
==========================================
  Files         179      179              
  Lines      134329   134300      -29     
  Branches   134329   134300      -29     
==========================================
- Hits       118923   118918       -5     
+ Misses      12656    12618      -38     
- Partials     2750     2764      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov