Emit DiscardFunding events for double spent splice transactions#4030
Merged
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom Aug 28, 2025
Merged
Conversation
|
👋 Thanks for assigning @jkczyz as a reviewer! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4030 +/- ##
==========================================
- Coverage 88.76% 88.74% -0.03%
==========================================
Files 175 176 +1
Lines 127895 128829 +934
Branches 127895 128829 +934
==========================================
+ Hits 113532 114325 +793
- Misses 11791 11904 +113
- Partials 2572 2600 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Once we see a splice transaction become locked, we want to emit a `DiscardFunding` event for every alternative funding transaction candidate that may have been negotiated due to RBFs, as they may contain inputs the user has considered "locked" that do not exist in the confirmed transaction. If the channel closes before the splice is locked, we rely on the `ChannelMonitor` to produce these events for us instead.
4deead3 to
51e342b
Compare
jkczyz
approved these changes
Aug 28, 2025
TheBlueMatt
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once we see a splice transaction become locked, we want to emit a
DiscardFundingevent for every alternative funding transaction candidate that may have been negotiated due to RBFs, as they may contain inputs the user has considered "locked" that do not exist in the confirmed transaction. If the channel closes before the splice is locked, we rely on theChannelMonitorto produce these events for us instead.