Fix multiplication overflow when logging hold times.#3888
Merged
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom Jun 24, 2025
Merged
Fix multiplication overflow when logging hold times.#3888TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
Conversation
With large reported hold times, the unit multiplication may exceed u32.
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
tnull
approved these changes
Jun 24, 2025
| "Htlc hold time at pos {}: {} ms", | ||
| route_hop_idx, | ||
| hold_time * HOLD_TIME_UNIT_MILLIS as u32 | ||
| (hold_time as u128) * HOLD_TIME_UNIT_MILLIS |
Contributor
There was a problem hiding this comment.
Agreed this would make an overflow highly unlikely, but saturating_mul would actually make it impossible. Doesn't matter much, as it's just in logging anyways.
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
TheBlueMatt
approved these changes
Jun 24, 2025
Collaborator
TheBlueMatt
left a comment
There was a problem hiding this comment.
saturating_mul is more readable, imo, but this is fine too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With large reported hold times, the unit multiplication may exceed u32.
Fixes #3885