Add option to generate outbound scid alias using intercept namespace#3839
Add option to generate outbound scid alias using intercept namespace#3839aylagreystone wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3839 +/- ##
==========================================
- Coverage 89.88% 89.84% -0.04%
==========================================
Files 160 160
Lines 129654 129670 +16
Branches 129654 129670 +16
==========================================
- Hits 116534 116507 -27
- Misses 10425 10458 +33
- Partials 2695 2705 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c2cf0b5 to
5b1d52f
Compare
5b1d52f to
363cf07
Compare
tnull
left a comment
There was a problem hiding this comment.
As mentioned on Discord, I don't think we should extend the intercept SCID concept much further. If we want to do generalized HTLC interception (#2855), we should finally do it 'properly', i.e., create an interface (e.g., a trait) that would allow users to intercept all HLTCs and then return an action to be taken. This could for example be similar to what CLN does with its hooks.
|
Going ahead and closing this as it has been superseded by the draft at #3843. |
Introduces a flag on
ChannelHandshakeConfigthat can be set to enable outbound scid alias generation to use the intercept namespace. This would allow users to selectively enable interception on channels and getHtlcInterceptedevents for every payment forwarded on those channels.