Fix remaining feedback and other nits for 2989#3219
Merged
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom Aug 6, 2024
Merged
Fix remaining feedback and other nits for 2989#3219TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3219 +/- ##
==========================================
+ Coverage 89.69% 89.74% +0.05%
==========================================
Files 122 122
Lines 101791 101791
Branches 101791 101791
==========================================
+ Hits 91300 91354 +54
+ Misses 7791 7755 -36
+ Partials 2700 2682 -18 ☔ View full report in Codecov by Sentry. |
775902d to
016d7e1
Compare
TheBlueMatt
approved these changes
Aug 6, 2024
Collaborator
TheBlueMatt
left a comment
There was a problem hiding this comment.
All super straightforward changes, gonna just land this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3170