Rename SocketAddress from NetAddress

[yanganto]

Fix #2358

Please change your imported crate from NetAddress to SocketAddress as the following.

- use lightning::ln::msgs::NetAddress;
+ use lightning::ln::msgs::SocketAddress;

Also, modify the type NetAddress::IPv4 to SocketAddress::TcpIpV4 and NetAddress::IPv6 to SocketAddress::TcpIpV6.

[codecov-commenter]

Codecov Report

Patch coverage: 93.50% and project coverage change: -0.05% ⚠️

Comparison is base (44b9c54) 90.63% compared to head (d34fcb8) 90.58%.
Report is 19 commits behind head on main.

❗ Current head d34fcb8 differs from pull request most recent head c2afb4a. Consider uploading reports for the commit c2afb4a to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2549      +/-   ##
==========================================
- Coverage   90.63%   90.58%   -0.05%     
==========================================
  Files         110      110              
  Lines       58199    57526     -673     
  Branches    58199    57526     -673     
==========================================
- Hits        52747    52111     -636     
+ Misses       5452     5415      -37     

Files Changed	Coverage Δ
lightning-net-tokio/src/lib.rs	75.55% <66.66%> (ø)
lightning/src/routing/gossip.rs	89.94% <66.66%> (ø)
lightning/src/ln/msgs.rs	85.82% <86.36%> (-0.39%)	⬇️
lightning/src/ln/peer_handler.rs	61.45% <100.00%> (ø)

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

[yanganto]

It seems that the failing test cases did not relate to this PR. If something I need to change on this PR, please kindly let me know. 🙏

[optout21]

Could you add to the PR description how users of LDK need to adapt their code? Just unroll the renames that has to be done (incl. in use statements). Otherwise LGTM.

[TheBlueMatt]

This LGTM, but I kinda want to land #2134, which is getting quite close, first if that's okay.

[yanganto]

This LGTM, but I kinda want to land #2134, which is getting quite close, first if that's okay.

Sure, and sorry about this. I did not check if there was a PR work on NetAddress before.

[TheBlueMatt]

All good, better than not opening it at all :)

[G8XSU]

LGTM,
verified that all instanced were renamed.

[tnull]

This needs a rebase now.

[tnull]

Could also consider renaming variables/methods that reflected the NetAddress type before, e.g., their_net_address in peer_handler::Peer and fn test_net_address_from_str in msgs.rs.

[valentinewallace]

Thanks for sticking with this!

[valentinewallace]

PR number is off

[TheBlueMatt]

We can fix it in post :)

[yanganto]

#2348 is the issue. I thought it was much clearer the reason we doing this, and also linked to the PR if the user wants to see the code diff.

[TheBlueMatt]

Ah, we normally link the PRs so that they go directly to the code changes.

[yanganto]

Got it, I will make it right in future PR