Update BOLT 12 test vectors#2334
Merged
TheBlueMatt merged 4 commits intolightningdevkit:mainfrom Jun 8, 2023
Merged
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2334 +/- ##
==========================================
+ Coverage 90.34% 91.49% +1.15%
==========================================
Files 104 104
Lines 53392 65514 +12122
Branches 53392 65514 +12122
==========================================
+ Hits 48237 59943 +11706
- Misses 5155 5571 +416
☔ View full report in Codecov by Sentry. |
dunxen
reviewed
Jun 4, 2023
d952596 to
798ac45
Compare
These were added to help debug an encoding issue. However, the encoding code was moved to the blinded_path module. Additionally, the test vector used an old TLV encoding.
The previous test vectors contained recurrences and older TLV types, and therefore couldn't be parsed. Update the tests with the latest test vectors from the spec and stop ignoring the tests.
The BOLT 12 test vectors had inadvertently left out a signature, but it has since been added. Include a signature check in the corresponding test for completeness.
798ac45 to
ecd283e
Compare
Contributor
Author
Accidentally committed some errant code that was meant for a later commit. Should be fixed now. |
TheBlueMatt
approved these changes
Jun 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous test vectors contained recurrences and older TLV types, and therefore couldn't be parsed. Update the tests with the latest test vectors from the spec and stop ignoring the tests. Additionally, the BOLT 12 test vectors had inadvertently left out a signature, but it has since been added. Include a signature check in the corresponding test for completeness.