Remove redundant final_cltv_delta param from get_route#2239
Merged
wpaulino merged 1 commit intolightningdevkit:mainfrom Apr 28, 2023
Merged
Conversation
PaymentParameters already includes this value. This set us up to better support route blinding, since there is no known final_cltv_delta when paying to a blinded route.
de7b990 to
cae41c1
Compare
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2239 +/- ##
==========================================
- Coverage 91.57% 91.56% -0.01%
==========================================
Files 104 104
Lines 51782 51781 -1
Branches 51782 51781 -1
==========================================
- Hits 47417 47413 -4
- Misses 4365 4368 +3
☔ View full report in Codecov by Sentry. |
wpaulino
approved these changes
Apr 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PaymentParametersalready includes this value.This set us up to better support route blinding, since there is no known final_cltv_delta when paying to a blinded route.