HTLC JIT channel interception followup + minor cleanups#1893
Conversation
ChannelUnavailable is a better fit for errors regarding unavailable channels than APIMisuseError. Also log bytes in errors as hex instead of decimal.
Soon we're going to need to return an error when ChannelManager is unable to find a route, so we'll need a way to distinguish between that and the user supplying an invalid route.
|
Not sure which follow-ups we'd like to include here, but just leaving another follow-up that I thought of that might be worth considering: I realized after the PR was merged, that I don't think we communicate well enough to the user that using the Intercept feature will break backwards compatibility. I think it would be good to add some docs to |
Let's add a release note for it. I'm not sure we need to litter it all over our docs. |
Ah yeah, sounds good. Didn't think about that :)! |
|
@valentinewallace can you add pending release notes like @ViktorTigerstrom suggests in another followup? Thanks. |
Closes #1890.
Because the changes were pretty trivial, I stuck on two minor commits that help prepare for moving payment retries.