lightning-invoice/utils: Actually add expiry to invoices#1474
lightning-invoice/utils: Actually add expiry to invoices#1474TheBlueMatt merged 2 commits intolightningdevkit:mainfrom
Conversation
983a462 to
b61a7a2
Compare
jkczyz
left a comment
There was a problem hiding this comment.
Thanks for the quick turnaround! We should have caught this in review, so no worries.
b61a7a2 to
ec774ff
Compare
Codecov Report
@@ Coverage Diff @@
## main #1474 +/- ##
==========================================
- Coverage 90.94% 90.93% -0.01%
==========================================
Files 75 75
Lines 41891 41900 +9
Branches 41891 41900 +9
==========================================
+ Hits 38097 38102 +5
- Misses 3794 3798 +4
Continue to review full report at Codecov.
|
ec774ff to
c962c18
Compare
|
Needs rebase, it appears? |
|
Rebasing |
Beat me to it. Was quite behind on my local. |
c962c18 to
717047c
Compare
jkczyz
left a comment
There was a problem hiding this comment.
Looks good modulo some test changes.
717047c to
3369b29
Compare
| channelmanager, keys_manager, network, amt_msat, description, duration | ||
| channelmanager, keys_manager, network, amt_msat, | ||
| description, duration, invoice_expiry_delta_secs |
There was a problem hiding this comment.
nit: would just wrap at 100 chars instead of making them evenly distributed to ease future automation
| let invoice = ::utils::create_phantom_invoice::<EnforcingSigner, &test_utils::TestKeysInterface>(Some(payment_amt), payment_hash, "test".to_string(), 3600, route_hints, &nodes[1].keys_manager, Currency::BitcoinTestnet).unwrap(); | ||
| let invoice = ::utils::create_phantom_invoice::< | ||
| EnforcingSigner, &test_utils::TestKeysInterface | ||
| >( |
There was a problem hiding this comment.
nit: bleh, I hate these kinds of blank lines. Better to \n\t after the = or run over 100 chars than this :(
There was a problem hiding this comment.
I'll get to these in a follow-up today :) (also Jeff's)
My bad.
I've also added the expiry to non-phantom invoice utilities.
This should now fix #1411