Add expiry to phantom invoice utility functions#1422
Add expiry to phantom invoice utility functions#1422valentinewallace merged 1 commit intolightningdevkit:mainfrom
Conversation
|
Hmm. So I assumed we don't need to pass in a payment secret anymore. If this is wrong then I can fix up. |
Codecov Report
@@ Coverage Diff @@
## main #1422 +/- ##
==========================================
+ Coverage 90.84% 90.85% +0.01%
==========================================
Files 74 74
Lines 41288 41361 +73
Branches 41288 41361 +73
==========================================
+ Hits 37507 37580 +73
Misses 3781 3781
Continue to review full report at Codecov.
|
lightning-invoice/src/utils.rs
Outdated
| amt_msat: Option<u64>, description_hash: Sha256, payment_hash: PaymentHash, | ||
| payment_secret: PaymentSecret, phantom_route_hints: Vec<PhantomRouteHints>, | ||
| keys_manager: K, network: Currency, | ||
| amt_msat: Option<u64>, payment_hash: Option<PaymentHash>, invoice_expiry_delta_secs: u32, description_hash: Sha256, phantom_route_hints: Vec<PhantomRouteHints>, keys_manager: K, network: Currency, |
There was a problem hiding this comment.
Lets break the line at least a bit so its not so long :). Try to break around 100 chars.
TheBlueMatt
left a comment
There was a problem hiding this comment.
Basically lg, is there a reason this is still draft?
Ah, just wanted to check on something. Thought I had made some mistake in my conceptual understand. Will promote it out of draft now :) |
bf41004 to
2d954c4
Compare
valentinewallace
left a comment
There was a problem hiding this comment.
Looks great! I'm ACK if CI passes
2d954c4 to
b741ca5
Compare
b741ca5 to
3170ac9
Compare
3170ac9 to
8f047ca
Compare
Closes #1411