Remove explicit print in lightning-net-tokio, reduce redundant block connection logging

[TheBlueMatt]

Fixes #980.

[codecov]

Codecov Report

Merging #1048 (35d0b7a) into main (64159b3) will increase coverage by 1.30%.
The diff coverage is 73.33%.

@@            Coverage Diff             @@
##             main    #1048      +/-   ##
==========================================
+ Coverage   90.96%   92.26%   +1.30%     
==========================================
  Files          64       65       +1     
  Lines       32447    38813    +6366     
==========================================
+ Hits        29515    35812    +6297     
- Misses       2932     3001      +69     

Impacted Files	Coverage Δ
lightning/src/ln/script.rs	93.75% <ø> (ø)
lightning-net-tokio/src/lib.rs	76.98% <50.00%> (-0.38%)	⬇️
lightning/src/ln/peer_handler.rs	45.75% <75.00%> (-0.23%)	⬇️
lightning/src/chain/chainmonitor.rs	95.91% <100.00%> (+0.11%)	⬆️
lightning/src/chain/channelmonitor.rs	91.97% <100.00%> (-0.02%)	⬇️
lightning/src/util/ser_macros.rs	90.50% <0.00%> (-5.24%)	⬇️
lightning/src/ln/shutdown_tests.rs	95.58% <0.00%> (ø)
lightning/src/ln/chanmon_update_fail_tests.rs	97.90% <0.00%> (+0.03%)	⬆️
lightning/src/ln/functional_tests.rs	98.66% <0.00%> (+1.36%)	⬆️
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64159b3...35d0b7a. Read the comment docs.

[TheBlueMatt]

Addressed feedback and added one more commit to clean up docs.

[valentinewallace]

suggestion: s/{}/txid {}

[TheBlueMatt]

How about Transaction {}?

[TheBlueMatt]

Pushed a trivial change as suggested by val and squashed, diff from Jeff's ACK:

$ git diff-tree -U1 77178c6 5d847048
diff --git a/lightning/src/chain/chainmonitor.rs b/lightning/src/chain/chainmonitor.rs
index 8100153a..8969427a 100644
--- a/lightning/src/chain/chainmonitor.rs
+++ b/lightning/src/chain/chainmonitor.rs
@@ -199,3 +199,3 @@ where
 	fn transaction_unconfirmed(&self, txid: &Txid) {
-		log_debug!(self.logger, "{} reorganized out of chain", txid);
+		log_debug!(self.logger, "Transaction {} reorganized out of chain", txid);
 		let monitors = self.monitors.read().unwrap();

[TheBlueMatt]

Oops, had to tweak the last commit cause I misunderstood doclinks, diff is trivial, so will land after CI:

$ git diff-tree -U1 5d847048 35d0b7aa
diff --git a/lightning/src/ln/script.rs b/lightning/src/ln/script.rs
index bee544ea..4e81d76a 100644
--- a/lightning/src/ln/script.rs
+++ b/lightning/src/ln/script.rs
@@ -90,3 +90,4 @@ impl ShutdownScript {
 	///
-	/// Note for version-zero witness scripts you must use [`new_p2wpkh`] or [`new_p2wsh`] instead.
+	/// Note for version-zero witness scripts you must use [`ShutdownScript::new_p2wpkh`] or
+	/// [`ShutdownScript::new_p2wsh`] instead.
 	///
$