Add serde serializers for Bytes and Enums in protos#122
Add serde serializers for Bytes and Enums in protos#122tnull merged 1 commit intolightningdevkit:mainfrom
Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
f02251f to
c45e341
Compare
|
🔔 1st Reminder Hey @tnull! This PR has been waiting for your review. |
tnull
left a comment
There was a problem hiding this comment.
Hmm, not the biggest fan of this approach, as it will add a lot of additional boilerplate here, that then surely will get stale/out-of-sync at some point. Do you see a way to avoid that? Could we maybe reuse some of the Server types rather than replicating them?
|
Okay found a much better way to do this. Only downside is we have the double |
c45e341 to
8c5c493
Compare
Adds serializers for bytevectors and enums defined in our proto files. This makes it so we can print out something like `"status": "SUCCEEDED"` instead of `"status": 1`.
8c5c493 to
af16148
Compare
Adds serializers for bytevectors and enums defined in our proto files.
This makes it so we can print out something like
"status": "SUCCEEDED"instead of"status": 1.before:
after: