persist payments info to disk#104
Conversation
c3c0473 to
b88e454
Compare
|
Thanks for having a go at this! I believe this unfortunately now needs a rebase! |
b88e454 to
7814899
Compare
|
No problem, it was an easy rebase! |
tnull
left a comment
There was a problem hiding this comment.
Generally looks good, comments mostly concerning serialization.
c8c446c to
5378d42
Compare
5378d42 to
9e0b09b
Compare
TheBlueMatt
left a comment
There was a problem hiding this comment.
Sorry for the delay in responding here, somehow this fell off my todo list.
9e0b09b to
339ea63
Compare
|
@TheBlueMatt could you please check if this can now be merged? |
TheBlueMatt
left a comment
There was a problem hiding this comment.
Grrrr, I am so sorry I missed this again somehow. It basically looks good to me with one missed update. When you push next, feel free to squash the fixup commits down into one commit.
339ea63 to
c54c387
Compare
No worries and thank you for the thorough review. I've fixed and squashed the fixup commits |
TheBlueMatt
left a comment
There was a problem hiding this comment.
LGTM! Instead of squashing to have one commit which does work and a second commit that fixes it, we should have only commits which stand on their own and don't have fixes to them in later commits. Because this is all kinda one big set of change you're welcome to squash it down to a single commit.
c54c387 to
5b00863
Compare
|
@TheBlueMatt I've squashed the commits into a single one |
5b00863 to
bd7121e
Compare
|
And also rebased since I've just noticed commit was not on top of current main |
This PR should close #90.
I hope the way I implemented this meets the goals of the sample (simplicity and readibility). I was a bit unsure on some styling details, if there's something you would like to be implemented differently I'd be happy to change it.