Add pre-flight probing capabilities#147
Merged
tnull merged 3 commits intolightningdevkit:mainfrom Aug 9, 2023
Merged
Conversation
996b623 to
87265a8
Compare
87265a8 to
92e2003
Compare
jkczyz
reviewed
Aug 8, 2023
src/lib.rs
Outdated
| })?; | ||
|
|
||
| for path in route.paths { | ||
| if path.hops.len() < 2 && path.blinded_tail.is_none() { |
Contributor
There was a problem hiding this comment.
Should we count the number of hops in the blinded tail, too?
Collaborator
Author
There was a problem hiding this comment.
Mh, good point. Tbh., I copied that check from https://github.com/lightningdevkit/rust-lightning/blob/7e3de7044896dbc4d2838f87870c7c58f2c7c756/lightning/src/ln/outbound_payment.rs#L907 to avoid the APIMisuseError here. I guess this could be change there, too? (cc @valentinewallace, if you happen to touch that sometime)
TheBlueMatt
reviewed
Aug 9, 2023
92e2003 to
ec422e0
Compare
jkczyz
reviewed
Aug 9, 2023
Contributor
jkczyz
left a comment
There was a problem hiding this comment.
LGTM. Feel free to squash.
We add the capability to send a payment probe given an invoice.
We add the capability to send a payment probe given an amount and a payee node id.
ec422e0 to
07364b8
Compare
Collaborator
Author
|
Squashed fixups without further changes. |
jkczyz
approved these changes
Aug 9, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19.
Users might want to send pre-flight probes to train our scorer before sending the actutal payment.
Here, we add the capability to send payment probes either given an invoice or given an amount and the payee
node_id.