Codex/app server restart #802
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -142,14 +142,21 @@ opencodex local config only if all restore steps succeeded. `remove` is an alias | |
|
|
||
| ## Models & Codex | ||
|
|
||
| ### `ocx sync [--restart-codex]` | ||
|
|
||
| Fetch the live model list from every configured provider and re-inject the merged catalog into Codex. | ||
| Run it after adding a provider or to refresh available models. | ||
|
|
||
| If long-lived Codex `app-server` processes are still running, `ocx sync` warns that they may keep | ||
| serving the previous in-memory model list even though `opencodex-catalog.json` / `models_cache.json` | ||
| were updated. Pass `--restart-codex` to send `SIGTERM` only to matching `codex … app-server` and | ||
| `codex-code-mode-host` processes owned by the current user (active turns may be interrupted). Broad | ||
| `pkill -f codex` matching is intentionally avoided. | ||
|
|
||
| ### `ocx sync-cache [--restart-codex]` | ||
|
|
||
| Invalidate Codex's local model picker cache so it is rebuilt from the active opencodex catalog. The | ||
| same stale-`app-server` warning and optional `--restart-codex` behavior as `ocx sync` apply. | ||
|
Comment on lines
+145
to
+159
There was a problem hiding this comment. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
rg -n -C 8 'SIGTERM|process\.platform|win32|app-server|code-mode-host' \
src/codex/app-server-processes.ts src/cli/index.tsRepository: lidge-jun/opencodex Length of output: 25366 🏁 Script executed: #!/bin/bash
set -euo pipefail
printf '%s\n' '--- process discovery implementation ---'
sed -n '232,370p' src/codex/app-server-processes.ts
printf '%s\n' '--- platform-aware matching and restart flow ---'
sed -n '367,515p' src/codex/app-server-processes.ts
printf '%s\n' '--- related tests and documentation references ---'
rg -n -C 4 'listWindowsSnapshots|restartCodexAppServers|afterCatalogWriteHandleAppServers|restart-codex|sync-cache' \
test tests src docs-site 2>/dev/null || true
printf '%s\n' '--- locale CLI documentation files ---'
find docs-site/src/content/docs -type f -path '*/cli.md' -print 2>/dev/null | sortRepository: lidge-jun/opencodex Length of output: 49661 🏁 Script executed: #!/bin/bash
set -euo pipefail
python3 - <<'PY'
from pathlib import Path
import re
paths = [
Path("docs-site/src/content/docs/reference/cli.md"),
Path("docs-site/src/content/docs/ja/reference/cli.md"),
Path("docs-site/src/content/docs/ko/reference/cli.md"),
Path("docs-site/src/content/docs/ru/reference/cli.md"),
Path("docs-site/src/content/docs/zh-cn/reference/cli.md"),
]
for path in paths:
lines = path.read_text(encoding="utf-8").splitlines()
starts = [i for i, line in enumerate(lines) if line.startswith("### `ocx sync")]
print(f"--- {path} ---")
for start in starts:
end = next((i for i in range(start + 1, len(lines))
if lines[i].startswith("### ")), len(lines))
block = lines[start:end]
print(f"lines {start + 1}-{end}:")
print("\n".join(block))
print("has_restart_flag=", any("--restart-codex" in line for line in block))
print("has_stale_warning=", any("app-server" in line or "app-server" in line.lower() for line in block))
PY
printf '%s\n' '--- platform dispatch and signal call ---'
rg -n -C 3 'defaultListSnapshots|platform === "win32"|process\.kill\(pid, signal\)|powershell\.exe|GetOwner' \
src/codex/app-server-processes.tsRepository: lidge-jun/opencodex Length of output: 5886 🌐 Web query:
💡 Result: On Windows, POSIX signals are not supported, meaning there is no direct equivalent to the termination behavior triggered by signals on non-Windows platforms [1][2]. However, Node.js provides emulation for specific signals when using process.kill or subprocess.kill [1][2]. When you use process.kill(pid, 'SIGTERM') or subprocess.kill('SIGTERM') on Windows: 1. Forced Termination: The signal is treated as an instruction for unconditional and abrupt termination [1][2]. The process is killed immediately, similar to how it would be handled by 'SIGKILL' [2]. 2. Signal Reporting: Despite the forced nature of the termination, Node.js emulates the behavior for child processes, meaning the subprocess will correctly report that it was terminated by 'SIGTERM' [1][2]. 3. No Graceful Shutdown: Because Windows does not support POSIX signals, a Node.js process on Windows cannot listen for or handle 'SIGTERM' to perform a graceful shutdown [1][3]. While you can register a listener for 'SIGTERM' in your code, it will not be triggered when the process is killed in this manner [1][4]. In summary, 'SIGTERM' on Windows acts as a forced kill rather than a request for graceful exit [1][2]. This behavior applies specifically to 'SIGINT', 'SIGTERM', 'SIGQUIT', and 'SIGKILL', which are the signals supported by the Node.js emulation layer on Windows [2][5]. Citations:
🏁 Script executed: #!/bin/bash
set -euo pipefail
python3 - <<'PY'
from pathlib import Path
paths = [
Path("docs-site/src/content/docs/reference/cli.md"),
Path("docs-site/src/content/docs/ja/reference/cli.md"),
Path("docs-site/src/content/docs/ko/reference/cli.md"),
Path("docs-site/src/content/docs/ru/reference/cli.md"),
Path("docs-site/src/content/docs/zh-cn/reference/cli.md"),
]
for path in paths:
lines = path.read_text(encoding="utf-8").splitlines()
starts = [i for i, line in enumerate(lines) if line.startswith("### `ocx sync")]
print(f"--- {path} ---")
for start in starts:
end = next(
(i for i in range(start + 1, len(lines)) if lines[i].startswith("### ")),
len(lines),
)
block = lines[start:end]
print(f"lines {start + 1}-{end}:")
print("\n".join(block))
print("has_restart_flag=", any("--restart-codex" in line for line in block))
print("has_stale_warning=", any("app-server" in line.lower() for line in block))
PY
printf '%s\n' '--- platform dispatch and signal call ---'
rg -n -C 3 'defaultListSnapshots|platform === "win32"|process\.kill\(pid, signal\)|powershell\.exe|GetOwner' \
src/codex/app-server-processes.tsRepository: lidge-jun/opencodex Length of output: 5886 Update the translated CLI pages.
🤖 Prompt for AI AgentsSource: Path instructions |
||
|
|
||
| ### `ocx v2 [subcommand]` | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Make all stale-process guidance reflect the write-status gate.
Stale warnings and restarts occur only after a successful catalog or cache write. No-op syncs do not terminate matching processes.
docs-site/src/content/docs/reference/cli.md#L150-L154: state that--restart-codexacts only after a successful write.docs-site/src/content/docs/guides/codex-integration.md#L194-L198: add the same condition to the warning and recovery steps.gui/src/pages/dashboard-overview-sections.tsx#L225-L225: ensureocx sync --restart-codexperforms a write after the API sync, or show a command that reliably rewrites the cache.📍 Affects 3 files
docs-site/src/content/docs/reference/cli.md#L150-L154(this comment)docs-site/src/content/docs/guides/codex-integration.md#L194-L198gui/src/pages/dashboard-overview-sections.tsx#L225-L225🤖 Prompt for AI Agents
Source: Path instructions