fix(cursor): support current Grok 4.5 Fast wire IDs - #797
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughCursor effort mapping now supports Grok low/medium/high tiers and places ChangesCursor effort wire-ID handling
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c879ec95ce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| */ | ||
| export function cursorWireModelIdWithEffort(baseModelId: string, effortSuffix: string): string { | ||
| if (baseModelId.endsWith("-fast")) { | ||
| return `${baseModelId.slice(0, -"-fast".length)}-${effortSuffix}-fast`; |
There was a problem hiding this comment.
Preserve the discovered Fast wire-ID ordering
When GetUsableModels returns only a legacy ID such as cursor-grok-4.5-fast-medium, isCursorModelAvailableForAccount deliberately keeps grok-4.5-fast visible, but every request is now unconditionally rewritten to grok-4.5-medium-fast. For the exact legacy-account context this compatibility branch handles, the selected model can therefore fail with ERROR_BAD_MODEL_NAME; either stop exposing legacy-only discoveries or retain the discovered ordering when constructing the request.
Useful? React with 👍 / 👎.
Summary
-fastfollows the effort tierlow/medium/higheffort namesgrok-4.5-fast-{effort}orderingWhy
Cursor now exposes Fast variants as IDs such as
cursor-grok-4.5-high-fast, while the adapter only matched and emittedgrok-4.5-fast-high. Live model filtering therefore removedcursor/grok-4.5-fastfrom the GUI and Codex catalog even when the account could use it, and direct requests selected a wire ID Cursor no longer serves.Cursor staff documented the current slug migration from
grok-4.5-fast-{medium,high,xhigh}tocursor-grok-4.5-{low,medium,high}-fast: https://forum.cursor.com/t/cursor-grok-4-5-high-fast-doesnt-offer-a-50-discount-at-all/165551/8Related context: #731 and the closed wrong-target PR #730.
User impact
Accounts whose live model list includes Grok 4.5 Fast can retain
cursor/grok-4.5-fastas a separately selectable model. Requests now send the matching trailing-Fast wire ID, including the default/top-tiergrok-4.5-high-fast.Test plan
bun test tests/cursor-discovery.test.ts tests/cursor-effort-suffix.test.tsbun run typecheckbun run prepushSummary by CodeRabbit
New Features
Bug Fixes