fix(providers): add China Coding Plan baseUrl choice for Alibaba - #776
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAlibaba Coding Plan now provides international, China mainland, and custom base URL choices. The registry uses the international endpoint by default, and parity tests validate the available choices and override support. ChangesAlibaba endpoint configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eef4064a03
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
[shipping-github] Merge-ready
|
Add a custom baseUrl choice so dashboard saves do not rewrite non-preset Coding Plan endpoints to the international default.
Registry now includes the custom endpoint option alongside intl and china presets.
Verdict: approve-comment
|
|
Merging this. Why it helps: China Coding Plan users can pick the mainland DashScope endpoint (or keep a custom URL) instead of being stuck on the international default. |
Summary
Fixes #756
Test plan
Security
Summary by CodeRabbit
New Features
Tests