fix(ci): soft-pass detailed issues after maintainer retitle - #564
Conversation
Issue lidge-jun#545 was auto-closed when a maintainer retitle dropped the [Bug]: prefix; soft-pass no longer requires the title prefix once kind is already established and the body has substantial structured content.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8cd659c9d1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const canSoftPass = | ||
| !mappedHeadingPresent && | ||
| titleLower.startsWith("[feature]:") && | ||
| hasSubstantialStructuredContent(body); |
There was a problem hiding this comment.
For any issue whose kind is recovered from its existing form label or active bot state, this now accepts an arbitrary body such as ## Notes followed by 40 characters because hasSubstantialStructuredContent requires only one sufficiently long section. The same weakened condition was added to bug and provider reports, and the workflow treats softPass as passing and may reopen a bot-closed issue, so an author can delete every required section and still bypass the quality gate. Require multiple substantive sections or kind-specific evidence rather than one arbitrary heading.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed: hasSubstantialStructuredContent now requires ≥2 rich h2–h4 sections (not one arbitrary heading). Single-section bypass covered by a regression.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/scripts/issue-quality.cjs:
- Around line 695-703: Update the mappedHeadingPresent guard in the soft-pass
logic to also consider provider, version, and endpoint metadata values,
preventing reports with only mapped metadata from soft-passing without required
behavior sections. Add a regression test covering populated mapped metadata with
substantial content but missing current and expected behavior headings.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 45e383ae-0c02-4b68-80a4-5b58d6841adc
📒 Files selected for processing (2)
.github/scripts/issue-quality.cjs.github/scripts/issue-quality.test.cjs
Require at least two rich markdown sections before soft-pass, and treat provider metadata headings as mapped so partial English forms cannot bypass Current/Expected behaviour.
Summary
[Bug]:/[Feature]:title prefix once issue kind is already established (label / stored kind) and the body has substantial structured content.Test plan
node --test .github/scripts/issue-quality.test.cjs(81/81)main(default branch), confirm a retitle of a substantial labeled bug no longer auto-closesNote: live
Enforce issue qualityloads scripts from the repo default branch (main), so this only takes effect after promotion fromdev.Summary by CodeRabbit
Bug Fixes
Tests