Skip to content

fix(ci): close freeform issue-quality template bypass - #523

Merged
Wibias merged 1 commit into
lidge-jun:devfrom
Wibias:fix/issue-quality-freeform-bypass
Jul 26, 2026
Merged

fix(ci): close freeform issue-quality template bypass#523
Wibias merged 1 commit into
lidge-jun:devfrom
Wibias:fix/issue-quality-freeform-bypass

Conversation

@Wibias

@Wibias Wibias commented Jul 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Freeform / API-opened issues with no detected template kind no longer skip the issue-quality gate (the old Issue is not a structured form; skipping validation. path).
  • Non-trusted authors are closed not_planned with clear guidance to use Bug/Feature/Documentation/Provider templates; near-miss bodies like Description/Reproduction/Log entry (499 client_closed_request errors during web-search tool usage #521-shaped) get a bug-template-specific message.
  • Trusted authors (OWNER/MEMBER/COLLABORATOR) remain exempt. Structured bug/feature/docs/provider validation is unchanged.

Test plan

  • node --test .github/scripts/issue-quality.test.cjs (77 pass)
  • Confirm after merge to dev that live gate behavior still loads scripts from default branch main until this change is promoted
  • Optional: workflow_dispatch on an untrusted freeform issue after promotion to main

Deployment note

Issue events load enforce-issue-quality.yml (and checked-out scripts) from the repository default branch (main), not dev. Landing on dev alone does not change live issue-quality behavior until promotion to main.

Summary by CodeRabbit

  • Bug Fixes
    • Improved issue validation to detect freeform bug reports that omit required template sections.
    • Unrecognized or incomplete issue submissions are now rejected instead of bypassing validation.
    • Validation messages now distinguish between missing templates and missing report details.
    • Added targeted guidance to help authors provide the required bug-report information.
    • Preserved support for valid structured bug reports and trusted-author exceptions.

Unclassified API/freeform issues no longer skip the gate; non-trusted authors are closed with template guidance (including lidge-jun#521-shaped near-miss headings).
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@github-actions github-actions Bot added the bug Something isn't working label Jul 26, 2026
@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: fef7ee4d-4dcf-49d0-92ee-1403eaf87080

📥 Commits

Reviewing files that changed from the base of the PR and between 49c63e1 and 30bd705.

📒 Files selected for processing (3)
  • .github/scripts/issue-quality.cjs
  • .github/scripts/issue-quality.test.cjs
  • .github/workflows/enforce-issue-quality.yml

📝 Walkthrough

Walkthrough

Unstructured issues are no longer skipped by validation. Bug-like near-miss reports receive targeted template guidance, generic freeform issues are rejected, and the workflow uses distinct closure messaging for missing templates.

Changes

Issue quality enforcement

Layer / File(s) Summary
Near-miss detection and validation
.github/scripts/issue-quality.cjs
Detects bug-like freeform headings, rejects unrecognized issue bodies, and exports the near-miss detector.
Freeform validation coverage
.github/scripts/issue-quality.test.cjs
Tests generic freeform rejection, near-miss detection, structured bug preservation, classification boundaries, and empty feature submissions.
Workflow enforcement and closure messaging
.github/workflows/enforce-issue-quality.yml
Routes unrecognized issues through validation and distinguishes missing-template closure comments from insufficient-detail comments.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Issue
  participant enforceIssueQuality
  participant validateIssue
  participant BotComment
  Issue->>enforceIssueQuality: submit unstructured issue
  enforceIssueQuality->>validateIssue: validate without resolved kind
  validateIssue-->>enforceIssueQuality: return invalid result
  enforceIssueQuality->>BotComment: write template-required guidance
Loading

Possibly related PRs

Suggested reviewers: ingwannu, lidge-jun

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately captures the main change: closing the freeform issue-quality template bypass.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@Wibias
Wibias merged commit 703c619 into lidge-jun:dev Jul 26, 2026
7 checks passed
@Wibias
Wibias deleted the fix/issue-quality-freeform-bypass branch July 27, 2026 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant