Fix stale Codex autostart shim repair - #5
Closed
Ingwannu wants to merge 1 commit into
Closed
Conversation
Owner
|
좋은 PR 감사합니다! 코어 로직은 정확하고 stale shim 감지 + repair 경로 추가가 잘 되어 있습니다. 하나 blocking suggestion이 있습니다: Repair 시 새 바이너리 보존 ( 현재 repair가 // 현재 (v2 바이너리 손실)
if (existsSync(existing.wrapperPath)) unlinkSync(existing.wrapperPath);
writeShim(existing.wrapperPath, existing.backupPath);
// 제안 (v2 바이너리를 백업으로 승격)
if (existsSync(existing.wrapperPath)) {
renameSync(existing.wrapperPath, existing.backupPath);
}
writeShim(existing.wrapperPath, existing.backupPath);이렇게 하면 Codex 업데이트 후 repair해도 최신 바이너리를 통해 실행됩니다. 수정 후 |
lidge-jun
added a commit
that referenced
this pull request
Jun 20, 2026
Add isShim() guard to prevent false "already installed" when wrapper was overwritten by a Codex update. Add repair path that rewrites the shim when the wrapper is missing or not an opencodex shim. Extract writeShim() helper. Improve codexShimStatus() to distinguish shim/non-shim/missing wrappers. Based on PR #5 by Ingwannu. Co-authored-by: Ingwannu <Ingwannu@users.noreply.github.com>
Owner
|
PR #5 변경사항을 dev에 머지하면서 repair 경로의 unlinkSync → renameSync 수정도 같이 적용했습니다. 추가로 shim 테스트 보강 + 문서화(README 3개 언어, docs-site CLI 레퍼런스, structure)도 완료했습니다. dev 커밋:
|
Owner
|
Already merged into main via direct commits. Closing stale PR. |
lidge-jun
added a commit
that referenced
this pull request
Jul 12, 2026
…p audit BLOCKER fixes: - outbound.ts: detached pump pattern for SSE streaming — frames now reach the client as they arrive instead of buffering until upstream EOF; cancel calls reader.cancel() instead of the locked stream (#1) - system-env.ts: transactional launchctl injection with incremental tracking and rollback on mid-flight failure (#2) MAJOR fixes: - system-env.ts: POSIX single-quote escaping for all user-controlled values in the generated shell file, preventing command injection (#3) - system-env.ts: exported applySystemEnvToggle for runtime ON/OFF lifecycle (#7) - claude-messages.ts: 120s hard timeout on native passthrough upstream fetch using AbortSignal.timeout, returning Anthropic 504 on expiry (#4) - management-api.ts: reject non-plain-object PUT bodies (null, array, primitive) with 400; strict validation for blockedSkills, tierModels, modelMap, and autoCompactWindow (integer, range 100k-1M) (#5, #6) - management-api.ts: call applySystemEnvToggle after systemEnv config toggle (#7) - cli/claude.ts: override stale loopback ANTHROPIC_BASE_URL with live port; warn on gateway-cache and agent-sync failures instead of swallowing (#8, #10) - gateway-cache.ts: distinguish discovery failure (keep cache) from authoritative empty success (write {models:[]}) (#9) Test fixes: updated assertions for single-quote shell escaping, empty cache semantics, validation messages, incremental tracking writes, and PUT response shape.
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests