fix(ci): reject low-effort feature reports in issue-quality bot - #423
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughIssue-quality validation recognizes expanded placeholder forms, distinguishes missing from placeholder examples, and rejects vague feature sections. The enforcement workflow supports manual issue validation with dispatch input and branch guards. ChangesIssue Quality Enforcement
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Dispatcher
participant EnforceIssueQuality
participant GitHubAPI
participant IssueQuality
Dispatcher->>EnforceIssueQuality: workflow_dispatch with issue_number and ref
EnforceIssueQuality->>IssueQuality: validate dispatch input and default branch
EnforceIssueQuality->>GitHubAPI: fetch issue by issue_number
GitHubAPI-->>EnforceIssueQuality: issue payload
EnforceIssueQuality->>IssueQuality: reject pull-request dispatch payload
IssueQuality-->>EnforceIssueQuality: rejection message or null
EnforceIssueQuality->>GitHubAPI: validate and enforce issue quality
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Ready |
- distinguish blank example sections from explicit placeholder tokens - scope workflow issues:write permission to the validate job - validate workflow_dispatch issue_number as a positive safe integer - add regression test for blank example usage
3b96465 to
70bb34b
Compare
Count Cyrillic/Greek/Arabic as real word tokens, reject fenced N/A-only examples, and cover the true 6-7 word concrete-detail boundary.
Count CJK glyphs separately from non-CJK tokens so stubs like provider中 cannot bypass the feature terseness check.
Why
Issue #401 stayed open because enforce-issue-quality.yml was working, but the validator treated that report as valid.
What changed
Test plan
Summary by CodeRabbit