fix(deps): raise fast-uri floor to 3.1.4 - #319
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesDependency override
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.3.8)package.jsonTraceback (most recent call last): Comment |
Ingwannu
left a comment
There was a problem hiding this comment.
Reviewed against current dev. The override changes only fast-uri from 3.1.2 to 3.1.4; GitHub advisory metadata confirms 3.1.4 is outside both affected 3.x ranges cited in the PR. I also integrated this lockfile change with the other shortlisted PRs and ran bun install --frozen-lockfile, focused tests, typecheck, privacy scan, docs build, and the full pre-push suite (3,667 passed / 0 failed). No unrelated dependency resolution moved. Approved.
…idge-jun#307/lidge-jun#309/lidge-jun#279/lidge-jun#303/lidge-jun#318/lidge-jun#319 + v2.7.34 joined with local lidge-jun#304 merge and lidge-jun#279 fixups (models-auth revert, abortable SSE decoder)
Summary
fast-urifrom3.1.2to3.1.4with a^3.1.4overrideand GHSA-4c8g-83qw-93j6
On
dev,bun auditreports three vulnerabilities: two high and one moderate. This branch reportsone moderate.
Why an override
fast-urienters through one path:@modelcontextprotocol/sdk@1.29.0→ajv@8.20.0→fast-uri. Ajv already allowsfast-uri ^3.0.1, but the existing lock resolved the affected3.1.2. The root override sets asafe floor within the same major line without forcing a parent upgrade or refreshing unrelated
packages.
The remaining moderate finding,
GHSA-frvp-7c67-39w9, is in
@hono/node-server. The current MCP SDK requires its 1.x line, while the fix starts at 2.0.5.OpenCodex uses the SDK's client transports; the vulnerable
serve-staticpath belongs to theserver adapter. That upgrade is left for a separate compatibility change.
Verification
bun install --frozen-lockfilebun run test— 3,617 passed, 4 skipped, 0 failedbun run typecheckbun run privacy:scanbun audit— bothfast-urifindings cleared; one pre-existing Hono moderate remainsgit diff --checkChecklist
Because this changes dependency resolution, it still requires explicit maintainer security review
before merge.
Summary by CodeRabbit