Skip to content
This repository was archived by the owner on Oct 18, 2023. It is now read-only.

Comments

Revert "fix db path"#184

Merged
bors[bot] merged 1 commit intomainfrom
revert-164-fix-db-path
Feb 11, 2023
Merged

Revert "fix db path"#184
bors[bot] merged 1 commit intomainfrom
revert-164-fix-db-path

Conversation

@MarinPostma
Copy link
Contributor

temporarily revert #164

@MarinPostma MarinPostma added the self-merge this pr was self-reviewed label Feb 11, 2023
@MarinPostma
Copy link
Contributor Author

bors merge

@MarinPostma
Copy link
Contributor Author

bors abort

@bors
Copy link
Contributor

bors bot commented Feb 11, 2023

Build succeeded:

@bors bors bot merged commit 36ad364 into main Feb 11, 2023
bors bot added a commit that referenced this pull request Feb 13, 2023
72: wal file improvements r=MarinPostma a=MarinPostma

this PR introduces some overall improvements to our custom WAL file format.

- The WAL file header is improved to contain more informartion:
    - the database UUID that the log is replicating
    - Fields like initial checksum, start_frame_index for log compaction
    - a magic number
- Each WAL frame is now preceded by a `WalFrameHeader`, that contains:
    - The running checksum of the pages, including the current page.
    - The id of the start_frame_index
    - the page_no of the of the page contained in the frame
    - size_after: 0 on non-commit frame, otherwise, equal to the size (in page), of the database after applying those frames. (passed to and from the `xFrame` call).
- Use of Zerocopy to serialize and deserialize frames



169: proto: encode uuid as string r=MarinPostma a=MarinPostma



191: Revert "Revert "fix db path"" r=MarinPostma a=MarinPostma

Reverts #184

192: .gitignore: ignore the new data directory r=psarna a=psarna

./data.sqld/ directory is runtime-only, so let's ignore it.

Co-authored-by: ad hoc <postma.marin@protonmail.com>
Co-authored-by: Piotr Sarna <sarna@chiselstrike.com>
@MarinPostma MarinPostma deleted the revert-164-fix-db-path branch August 25, 2023 13:06
MarinPostma added a commit to tursodatabase/libsql that referenced this pull request Oct 17, 2023
72: wal file improvements r=MarinPostma a=MarinPostma

this PR introduces some overall improvements to our custom WAL file format.

- The WAL file header is improved to contain more informartion:
    - the database UUID that the log is replicating
    - Fields like initial checksum, start_frame_index for log compaction
    - a magic number
- Each WAL frame is now preceded by a `WalFrameHeader`, that contains:
    - The running checksum of the pages, including the current page.
    - The id of the start_frame_index
    - the page_no of the of the page contained in the frame
    - size_after: 0 on non-commit frame, otherwise, equal to the size (in page), of the database after applying those frames. (passed to and from the `xFrame` call).
- Use of Zerocopy to serialize and deserialize frames



169: proto: encode uuid as string r=MarinPostma a=MarinPostma



191: Revert "Revert "fix db path"" r=MarinPostma a=MarinPostma

Reverts libsql/sqld#184

192: .gitignore: ignore the new data directory r=psarna a=psarna

./data.sqld/ directory is runtime-only, so let's ignore it.

Co-authored-by: ad hoc <postma.marin@protonmail.com>
Co-authored-by: Piotr Sarna <sarna@chiselstrike.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

self-merge this pr was self-reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant