refactor(rest): port DigitalReproductionAPI to Java - #1814
Merged
Conversation
… there's no Groovy code left
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clanker-assisted port, but I've gone over every single line and compared with the original.
Split into multiple files since there were several separate classes in one single Groovy file.
Also added some (generated) tests.
Also changed
build.gradlesince after this change there's no more Groovy code inrest/(apart from the tests), so we don't have to pass the code through the Groovy compiler anymore. Instead it goes to directly to javac which speeds up compilation a bit.