Conversation
romanb
approved these changes
Jan 12, 2021
Contributor
|
Published as |
Contributor
|
Thanks for the fix @tomaka, the auto-import (rust-analyser?) feature in my IDE doesn't choose std exports over re-exports - so no 'real' reason the serde re-export was used, just a mistake 😄 |
sdbondi
added a commit
to tari-project/rust-libp2p
that referenced
this pull request
Jan 13, 2021
In serde 1.0.119, the export module is no longer public which breaks the build.
mxinden
pushed a commit
to mxinden/rust-libp2p
that referenced
this pull request
Jan 14, 2021
13 tasks
mxinden
added a commit
that referenced
this pull request
Jan 14, 2021
* Update onion_addr.rs (#1912) * misc/multiaddr: Prepare v0.9.7 release Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have no idea why, but the person who introduced this code decided to use
serde::export::Formatter, which is a hidden export not supposed to be used, instead ofstd::fmt::Formatter, even though they're the same thing.In serde 1.0.119, the
exportmodule is no longer public, which broke the build.