Chore: resolve aislop findings across codebase

[ModeSevenIndustrialSolutions]

Summary

Eliminates all aislop code-quality findings and adds the aislop quality
gate as a pre-commit hook (basedpyright was already configured and remains
clean). All changes are behaviour-preserving; the full test suite,
ruff, basedpyright and mypy all pass, and aislop ci reports score 100.

Substantive ai-slop findings

• sitecustomize.py: convert three best-effort except Exception: pass
  swallows to log via the existing gated _dbg helper (observability), and
  suppress the gated stderr debug print (a startup-hook debug logger, not
  leftover debug) with an inline rationale.
• gerrit_ssh.py: include the caught exception in the temp-dir cleanup debug
  log so the failure cause is no longer lost (silent-recovery).
• gerrit_urls.py: file-level suppress hardcoded-url false positives — the
  module builds Gerrit URLs from a runtime host, so the https:// literals are
  URL schemes in f-strings, not hardcoded environment endpoints.

Tooling

• Add the aislop local pre-commit hook and .aislop/config.yml
  (maxFileLoc: 900, failBelow: 100); skip aislop and gha-workflow-linter
  on pre-commit.ci (network sandbox).

Complexity refactors (behaviour-preserving)

Decompose every over-long function (>80 LOC) and flatten every deeply nested
block (>5 levels) into cohesive private helpers across core.py, cli.py,
gerrit_pr_closer.py, duplicate_detection.py, external_api.py,
gerrit_urls.py, reconcile_matcher.py, config.py, ssh_discovery.py,
ssh_agent_setup.py, commit_normalization.py and
orchestrator/reconciliation.py. Cohesive parameter groups were bundled into
small frozen dataclasses / NamedTuples to avoid trading the findings for
too-many-params.

Review feedback & CI fixes

• gerrit_urls._location_to_path (Copilot): treat a relative redirect
  Location without a leading slash (e.g. r/dashboard/self) as absolute from
  root, so it is not folded into the netloc and the base-path segment survives.
• ssh_discovery._ensure_keyscan_available (Copilot): let the
  "ssh-keyscan not found" SSHDiscoveryError propagate instead of being
  re-wrapped as a generic "check failed" error, preserving the actionable
  message.
• gerrit_pr_closer._apply_pr_close_action (Copilot): describe the closed
  change using its real Gerrit status (merged / open / abandoned) rather than
  always logging "abandoned", which was inaccurate for MERGED/NEW/UNKNOWN.
• Grype dependency audit (CI red): bump the transitive setuptools pin
  80.9.0 -> 83.0.0 to clear GHSA-h35f-9h28-mq5c (Medium).
• Added regression tests for the three review fixes.

File size

maxFileLoc is calibrated to 900 to fit this codebase's cohesive
single-responsibility modules (19 files in the 450–900 range are normal for the
domain). The three orchestration god-files (core.py, cli.py,
gerrit_pr_closer.py) carry documented in-file file-level suppressions: their
long functions and deep nesting are decomposed here, but a full module/class
split is a large, dedicated follow-up refactor tracked separately.

Validation

• uv run pytest — full suite passes (added regression tests for the fixes)
• ruff check / ruff format --check (v0.15.21, matching the pinned hook) — clean
• basedpyright — 0 errors, 0 warnings
• mypy — clean
• aislop ci — score 100, exit 0

Note: this is a large, mechanical refactor produced with careful
behaviour preservation and validated against the comprehensive test suite.
Opened as draft pending Copilot review, green CI, and manual review — the
per-file helper extractions are worth a careful eyeball, especially the
SSH/config parsing paths.

[Copilot]

Pull request overview

This PR removes all reported aislop code-quality findings by performing behavior-preserving refactors across the Python codebase, and adds aislop as a local pre-commit quality gate with a repository-specific .aislop/config.yml.

Changes:

• Add aislop configuration and a local pre-commit hook, and skip it on pre-commit.ci due to sandbox/network constraints.
• Refactor multiple large functions into smaller helpers (SSH discovery/agent cleanup, reconciliation orchestration/matching, duplicate detection, config preprocessing, API retry framework) while preserving behavior.
• Improve diagnostics in a few paths (e.g., temp-dir cleanup logging, startup-hook debug behavior).

Reviewed changes

Copilot reviewed 14 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/github2gerrit/ssh_discovery.py	Extracts keyscan/connectivity/output-validation helpers for host key discovery.
src/github2gerrit/ssh_agent_setup.py	Factors secure temp-file overwrite and agent cleanup into helpers.
src/github2gerrit/reconcile_matcher.py	Decomposes reconciliation into helper passes and Change-Id assignment steps.
src/github2gerrit/orchestrator/reconciliation.py	Extracts similarity-threshold computation and reconciliation sub-paths into helpers.
src/github2gerrit/gerrit_urls.py	Adds file-level aislop suppression and refactors base-path discovery into helpers/constants.
src/github2gerrit/gerrit_ssh.py	Improves debug logging by including the caught exception during cleanup.
src/github2gerrit/gerrit_pr_closer.py	Refactors PR-closing and Gerrit-abandon flows into cohesive helpers and small dataclasses.
src/github2gerrit/external_api.py	Splits transient-error classification and retry handling into smaller composable helpers; adds default retry-policy resolver.
src/github2gerrit/duplicate_detection.py	Extracts normalization, query building, candidate scoring, and reporting into helpers/NamedTuples.
src/github2gerrit/config.py	Refactors INI preprocessing for multiline quoted values into dedicated helper functions.
src/github2gerrit/commit_normalization.py	Extracts release-drafter parsing and rule application into helper methods.
src/github2gerrit/cli.py	Large mechanical refactor: splits main()/processing paths into many helpers, including bulk and single-PR flows.
sitecustomize.py	Converts silent exception swallows into gated debug logging and adds an inline aislop suppression for the gated print.
.pre-commit-config.yaml	Adds a local aislop hook and updates pre-commit.ci skip list/documentation.
.aislop/config.yml	Introduces the aislop quality-gate configuration (maxFileLoc/failBelow) and rationale.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 17 out of 20 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 17 out of 20 changed files in this pull request and generated 4 comments.

[Copilot]

Pull request overview

Copilot reviewed 18 out of 21 changed files in this pull request and generated no new comments.