fix(SUP-3293): add MCP timeout + triggerless capture fallback - #94
fix(SUP-3293): add MCP timeout + triggerless capture fallback#94levineam wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 55 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 031626c776
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }; | ||
| const routingInput = { | ||
| ...captureEvent, | ||
| trigger: isLikelyProgrammaticCapture(captureEvent) ? 'note' : captureEvent.trigger, |
There was a problem hiding this comment.
When a programmatic capture has both a title and body, this ternary forces trigger: 'note' even if the normalized event already has an explicit trigger: 'idea' or the text starts with idea:. In that scenario substantive idea captures are routed into Notes instead of the Ideas journal section; the existing universal-capture.test.js case for promoting substantive ideas now fails with note !== idea.
Useful? React with 👍 / 👎.
|
Closing as duplicate of #93 (U2 triage of the jarvOS On-Track Plan, SUP-3329). Both PRs address SUP-3293 with identical file sets; #93 is a strict superset — it adds the same MCP tool timeout plus explicit trigger:'note' forcing in noteCaptureArgs(), which also fixes the triggerless-capture drop. #93 is the survivor and will go through review to merge. |
Why
jarvos_create_notecould hang indefinitely.What changed
modules/jarvos-agent-context/scripts/jarvos-mcp.js.jarvos_create_notepath await completion so the timeout can complete.modules/jarvos-secondbrain/bridge/capture/src/universal-capture.jsand defaulted to note routing when title+content are present with a tool source.modules/jarvos-secondbrain/tests/universal-capture.test.jsto validate triggerless title+content capture is routed to note and CLI exits with success.