feat(SUP-2214): promote jarvos coding host adapters - #65
Conversation
|
Warning Review limit reached
More reviews will be available in 2 minutes and 10 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (21)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5058a5d7ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const issue = input.issue || {}; | ||
| const identifier = issue.identifier || input.issueIdentifier; | ||
| if (!identifier || !branch) return false; | ||
| return String(branch).toLowerCase().includes(String(identifier).toLowerCase()); |
There was a problem hiding this comment.
When the submission gate is evaluated for an issue whose identifier is a prefix of another issue, this substring check marks the wrong branch as issue-named; for example, issue.identifier: "SUP-22" with git.branch: "SUP-2214/foo" currently passes branch_hygiene and can make the gate ready for the wrong ticket. This should compare normalized issue identifiers as tokens, like the stricter branchSatisfiesIdentifier helper does.
Useful? React with 👍 / 👎.
| title: options.title || 'jarvOS Coding', | ||
| description: options.description || 'Run the portable jarvOS coding orchestrator from this host.', | ||
| host, | ||
| invokes: DEFAULT_MCP_TOOL_NAME, |
There was a problem hiding this comment.
If a host customizes options.mcpTool.name, the adapter registers that custom tool but the skill descriptor still advertises jarvos_coding_take_issue_to_done, so invoking the registered skill points at a different/nonexistent tool. The skill descriptor should use the actual tool descriptor name (or accept an invokes override) when createCodingHostAdapter builds both surfaces.
Useful? React with 👍 / 👎.
Summary
jarvos-codinginto the public jarvOS repo asmodules/jarvos-coding/@jarvos/coding.jarvos_coding_take_issue_to_donetool plus ajarvos-codingskill descriptor, then invoke the sharedrunTakeIssueToDoneorchestrator.This supersedes the descriptor-only host contract noted on SUP-2214. It also intentionally overlaps the still-open jarvOS PR #64 by carrying the public module promotion forward with the host-adapter substance required by SUP-2214.
Validation
npm test --prefix modules/jarvos-codingnode -e "const coding = require('./modules/jarvos-coding/src'); console.log(JSON.stringify({loaded: true, hasClaude: typeof coding.createClaudeCodeHostAdapter, hasCodex: typeof coding.createCodexHostAdapter, pkg: require('./modules/jarvos-coding/package.json').name}))"node tests/modules-smoke-test.jsbash scripts/smoke-test.shnpm pack --dry-run --jsonfrommodules/jarvos-codinggit diff --checknpm testPaperclip: SUP-2214