feat(SUP-1804): ship Capture Your Thoughts release - #47
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (13)
✅ Files skipped from review due to trivial changes (4)
🚧 Files skipped from review as they are similar to previous changes (5)
📝 WalkthroughWalkthroughThis PR releases v0.2.0 of Changesv0.2.0 Release: Capture Routing & Skill Contracts
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 45009c1fcc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ".": "./src/index.js", | ||
| "./routing": "./bridge/routing/src/keyword-capture-router.js", | ||
| "./routing/contracts": "./bridge/routing/src/skill-contracts.js", | ||
| "./config": "./bridge/config/jarvos-paths.js" | ||
| }, |
There was a problem hiding this comment.
When v0.2.0 is consumed as an installed package, this new exports map blocks the deep import @jarvos/secondbrain/bridge/config/jarvos-paths.js; Node raises ERR_PACKAGE_PATH_NOT_EXPORTED even though the file is included. I checked the repo consumers and both modules/jarvos-agent-context/src/index.js and modules/jarvos-gbrain/src/index.js still resolve that exact subpath; the agent-context fallback only works in the monorepo layout, so packaged installs lose shared path resolution. Please either keep that legacy subpath in exports or update the consumers before publishing this map.
Useful? React with 👍 / 👎.
| journalSection: FLAGGED_HEADING, | ||
| journalLine: flaggedJournalLine(capture), |
There was a problem hiding this comment.
For medium-confidence captures on a journal file that already exists without the new ## 🚩 Flagged heading, this route now calls appendLineToJournalSection with FLAGGED_HEADING, and that adapter throws when the heading is missing instead of normalizing existing files. This affects users who update mid-day or have journals created before this release; the same capture that should be queued for review fails entirely. Ensure the section is materialized/migrated before appending, or fall back to an existing section.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/releases/v0.2.0.md`:
- Around line 51-55: Update the release notes so the dry-run pack is scoped to
the secondbrain package by replacing the standalone "npm pack --dry-run" entry
with the command that runs it in the module directory: "cd
modules/jarvos-secondbrain && npm pack --dry-run"; ensure the sequence shows
changing directory before the pack step and keeps the surrounding commands ("npm
test", "cd modules/jarvos-secondbrain && npm test", and "npm run release:check")
intact.
In `@modules/jarvos-secondbrain/adapters/obsidian/src/vault-storage-adapter.js`:
- Around line 174-179: The module's export list was updated but never exposes
NOTES_CREATED_HEADING, causing downstream imports to be undefined; locate the
constant (or create it) named NOTES_CREATED_HEADING in this file and add it to
the module.exports list (alongside createVaultStorageAdapter, FLAGGED_HEADING,
IDEAS_HEADING, NOTES_HEADING, todayDate) or, if the needed value already exists
under a different name, export that identifier as NOTES_CREATED_HEADING so the
re-export in modules/jarvos-secondbrain/adapters/index.js resolves correctly.
In `@modules/jarvos-secondbrain/bridge/routing/src/keyword-capture-router.js`:
- Around line 150-195: classifyCaptureIntent drops explicit capture.route ===
FLAGGED because normalizeTrigger/detectTrigger only recognizes IDEA|NOTE; update
the trigger normalization to accept 'flagged' (or add a branch in detectTrigger)
so an explicit capture.route of FLAGGED maps to the FLAGGED constant, then
ensure classifyCaptureIntent handles that returned FLAGGED path (route: FLAGGED,
reviewRequired: true, skillIds: [JOURNAL_ENTRY], reason:
'explicit-flagged-capture' or reuse existing flagged branch). Reference:
detectTrigger, normalizeTrigger, classifyCaptureIntent, and the FLAGGED
constant.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b685b002-6dfb-4b21-90d8-8192aa4f9055
📒 Files selected for processing (14)
CHANGELOG.mddocs/releases/v0.2.0.mdmodules/jarvos-secondbrain/README.mdmodules/jarvos-secondbrain/adapters/index.jsmodules/jarvos-secondbrain/adapters/obsidian/src/vault-storage-adapter.jsmodules/jarvos-secondbrain/bridge/routing/README.mdmodules/jarvos-secondbrain/bridge/routing/src/keyword-capture-router.jsmodules/jarvos-secondbrain/bridge/routing/src/skill-contracts.jsmodules/jarvos-secondbrain/package.jsonmodules/jarvos-secondbrain/packages/jarvos-secondbrain-journal/config/journal-module.jsonmodules/jarvos-secondbrain/src/index.jsmodules/jarvos-secondbrain/tests/keyword-capture-router.test.jspackage.jsontests/modules-smoke-test.js
| ```bash | ||
| npm test | ||
| cd modules/jarvos-secondbrain && npm test | ||
| npm pack --dry-run | ||
| npm run release:check |
There was a problem hiding this comment.
Scope npm pack --dry-run to the secondbrain module package.
This command currently validates the repo root package, not @jarvos/secondbrain. Update it so verification checks the intended publish artifact.
📌 Proposed docs fix
```bash
npm test
cd modules/jarvos-secondbrain && npm test
-npm pack --dry-run
+cd modules/jarvos-secondbrain && npm pack --dry-run
npm run release:check</details>
<details>
<summary>🤖 Prompt for AI Agents</summary>
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @docs/releases/v0.2.0.md around lines 51 - 55, Update the release notes so
the dry-run pack is scoped to the secondbrain package by replacing the
standalone "npm pack --dry-run" entry with the command that runs it in the
module directory: "cd modules/jarvos-secondbrain && npm pack --dry-run"; ensure
the sequence shows changing directory before the pack step and keeps the
surrounding commands ("npm test", "cd modules/jarvos-secondbrain && npm test",
and "npm run release:check") intact.
</details>
<!-- fingerprinting:phantom:triton:hawk -->
<!-- This is an auto-generated comment by CodeRabbit -->
| module.exports = { | ||
| createVaultStorageAdapter, | ||
| FLAGGED_HEADING, | ||
| IDEAS_HEADING, | ||
| NOTES_HEADING, | ||
| todayDate, |
There was a problem hiding this comment.
Export contract mismatch: NOTES_CREATED_HEADING is missing at source.
Line [176] updates exports, but this module still does not export NOTES_CREATED_HEADING, while modules/jarvos-secondbrain/adapters/index.js imports/re-exports it. That makes the downstream export undefined.
Proposed fix
const IDEAS_HEADING = '## 💡 Ideas';
const FLAGGED_HEADING = '## 🚩 Flagged';
+const NOTES_CREATED_HEADING = '## 🗂️ Notes Created';
const SIGNATURE = '— Edited by Jarvis';
@@
module.exports = {
createVaultStorageAdapter,
FLAGGED_HEADING,
IDEAS_HEADING,
NOTES_HEADING,
+ NOTES_CREATED_HEADING,
todayDate,
};🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@modules/jarvos-secondbrain/adapters/obsidian/src/vault-storage-adapter.js`
around lines 174 - 179, The module's export list was updated but never exposes
NOTES_CREATED_HEADING, causing downstream imports to be undefined; locate the
constant (or create it) named NOTES_CREATED_HEADING in this file and add it to
the module.exports list (alongside createVaultStorageAdapter, FLAGGED_HEADING,
IDEAS_HEADING, NOTES_HEADING, todayDate) or, if the needed value already exists
under a different name, export that identifier as NOTES_CREATED_HEADING so the
re-export in modules/jarvos-secondbrain/adapters/index.js resolves correctly.
45009c1 to
b97db45
Compare
There was a problem hiding this comment.
💡 Codex Review
Accept explicit flagged trigger in route normalization
The new review-first flow introduces flagged, but normalizeTrigger still only allows idea and note, even though detectTrigger reads explicit override fields like capture.trigger and capture.route. As a result, callers that pass an explicit route: 'flagged'/trigger: 'flagged' (for example, forwarding classifier output) fall through to no-capture-intent and get dropped instead of being queued in the Flagged section, which silently loses captures whenever the text itself doesn’t match the keyword patterns.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
@jarvos/secondbrain## 💡 Ideas, notes to durable markdown notes with journal wiki-links, ambiguous captures to## 🚩 Flaggedjournal-entry,note-creation, andidea-parkingVerification
npm testcd modules/jarvos-secondbrain && npm testnpm pack --dry-runinmodules/jarvos-secondbrainnpm install /Users/andrew/clawd-worktrees/SUP-1804-paperclip/modules/jarvos-secondbrain --package-lock=false --ignore-scriptsplus API import smokenpm run release:checkPaperclip
SUP-1804
Summary by CodeRabbit
Release Notes
New Features
Documentation
Chores